pgwire: handle negative scale#160499
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
DrewKimball
left a comment
There was a problem hiding this comment.
Nice work!
@DrewKimball reviewed 2 files and all commit messages, and made 4 comments.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dils2k).
-- commits line 10 at r1:
nit: You don't need the "Informs" line when you already have "Fixes".
pkg/sql/pgwire/testdata/pgtest/decimal line 112 at r1 (raw file):
{"Type":"ReadyForQuery","TxStatus":"I"} send
Let's add a comment to explain that this is a regression test for #158884.
pkg/sql/pgwire/testdata/pgtest/decimal line 125 at r1 (raw file):
{"Type":"ParseComplete"} {"Type":"ErrorResponse","Code":"22P03"} {"Type":"ReadyForQuery","TxStatus":"I"}
nit: Looks like you're missing a newline at the end of the file.
83b150c to
124b549
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
@DrewKimball PTAL |
DrewKimball
left a comment
There was a problem hiding this comment.
@DrewKimball reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:
The node could crash if it received a decimal with a negative scale value. This commit adds a check and returns an error instead. Epic: CRDB-57539 Fixes: cockroachdb#158884 Release note (bug fix): CockroachDB could previously crash when handling decimals with negative scales via extended PGWire protocol and this has been fixed (an error is returned, similar to PG).
124b549 to
65ee633
Compare
yuzefovich
left a comment
There was a problem hiding this comment.
I added the bug fix release note. Thanks for your contribution!
bors r=drewkimball,yuzefovich
@yuzefovich reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
159819: cmd: add ghsearchdump and ghweeklysummary r=wenyihu6 a=wenyihu6 Epic: none Release note: none --- **ghsearchdump** --- **cmd/ghweeklysummary: add tool for generating weekly PR summaries** ``` Example usage: # Last 1 week go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1 # Specific date range go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --after 2025-01-01 --before 2025-02-01 # Save to file go run ./pkg/cmd/ghweeklysummary --author wenyihu6 > weekly_summary.md ``` Release Notes: None Epic: None --- **cmd: move kv dev tools under pkg/cmd/kv/** Move ghsearchdump and ghweeklysummary under pkg/cmd/kv/ for clearer ownership. This seems okay given we already have pkg/cmd/allocsim. ``` Example usage: ❯ go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1 ❯ go run ./pkg/cmd/kv/ghsearchdump \ --search "repo:cockroachdb/cockroach author:wenyihu6" \ --contribution-after 2025-12-12 tracking contributions from: [wenyihu6] ``` 160459: kvserver: add tracing to TestStoreRangeSplitBackpressureWrites r=tbg a=stevendanna In #160141 we observed this test fail. This test is rather stable but does depend on two goroutines sending batches to the KV server within a 100ms timeout. One suspicion is that very rarely we are too slow and this time-based coordination is not enough. This test is rather stable and adding more sophisticated coordination will further complicate an already complicated test. Here, I add some tracing that will hopefully allow us to confirm the timing based theory if this ever happens again. Fixes #160141 Release note: None 160499: pgwire: handle negative scale r=drewkimball,yuzefovich a=dils2k The node could crash if it received a decimal with a negative scale value. This commit adds a check and returns an error instead. Epic: CRDB-57539 Fixes: #158884 Release note (bug fix): CockroachDB could previously crash when handling decimals with negative scales via extended PGWire protocol and this has been fixed (an error is returned, similar to PG). 160526: sql: fix TestUnsplitRanges to work with external test tenants r=rafiss a=rafiss Previously, TestUnsplitRanges was skipped in external test tenant mode because it scanned meta ranges directly and performed AdminSplit/ AdminUnsplit operations that external tenants cannot do. This commit fixes the test by: 1. Using the system layer's DB for meta range operations (scanning meta ranges, checking sticky bits, splitting ranges) since tenants cannot access meta ranges directly. 2. Using the application layer's DB for table data operations which tenants can access. 3. Granting the CanAdminUnsplit capability to the external tenant so the GC job can unsplit ranges after dropping tables/indexes. Resolves: #142388 Epic: CRDB-48944 Release note: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: dils2k <dils.matchanov@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
|
Build failed (retrying...): |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #158884: branch-release-25.4, branch-release-26.1. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. 💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details. error creating merge commit from 65ee633 to blathers/backport-release-25.4-160499: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 25.4.x failed. See errors above. 💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details. error creating merge commit from 65ee633 to blathers/backport-release-26.1-160499: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 26.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
blathers backport release-26.1 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. 💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details. error creating merge commit from 65ee633 to blathers/backport-release-26.1-160499: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-26.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
The node could crash if it received a decimal with a negative scale value. This commit adds a check and returns an error instead.
Epic: CRDB-57539
Fixes: #158884
Release note (bug fix): CockroachDB could previously crash when handling decimals with negative scales via extended PGWire protocol and this has been fixed (an error is returned, similar to PG).