Skip to content

cmd: add ghsearchdump and ghweeklysummary#159819

Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom
wenyihu6:prdump
Jan 6, 2026
Merged

cmd: add ghsearchdump and ghweeklysummary#159819
craig[bot] merged 3 commits intocockroachdb:masterfrom
wenyihu6:prdump

Conversation

@wenyihu6
Copy link
Copy Markdown
Contributor

@wenyihu6 wenyihu6 commented Dec 18, 2025

Epic: none
Release note: none


ghsearchdump


cmd/ghweeklysummary: add tool for generating weekly PR summaries

Example usage:

# Last 1 week
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1

# Specific date range
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --after 2025-01-01 --before 2025-02-01

# Save to file
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 > weekly_summary.md

Release Notes: None
Epic: None


cmd: move kv dev tools under pkg/cmd/kv/

Move ghsearchdump and ghweeklysummary under pkg/cmd/kv/ for clearer
ownership. This seems okay given we already have pkg/cmd/allocsim.

Example usage:

❯ go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1

❯ go run ./pkg/cmd/kv/ghsearchdump \
  --search "repo:cockroachdb/cockroach author:wenyihu6" \
  --contribution-after 2025-12-12
tracking contributions from: [wenyihu6]

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Dec 18, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@wenyihu6 wenyihu6 changed the title ghsearchdump cmd/ghsearchdump: add tool to generate pr summaries Dec 18, 2025
@wenyihu6 wenyihu6 changed the title cmd/ghsearchdump: add tool to generate pr summaries cmd: add tool to generate pr summaries Dec 18, 2025
@wenyihu6 wenyihu6 marked this pull request as ready for review December 19, 2025 14:10
@wenyihu6 wenyihu6 requested a review from tbg December 19, 2025 14:10
@wenyihu6 wenyihu6 changed the title cmd: add tool to generate pr summaries cmd: add ghsearchdump and ghweeklysummary Dec 19, 2025
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Dec 19, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link
Copy Markdown
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM (no line by line review)
Lint needs a fix.
Please socialize on the team when it's in 😄

tbg and others added 2 commits January 6, 2026 10:37
Example usage:

# Last 1 week
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1

# Specific date range
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --after 2025-01-01 --before 2025-02-01

# Save to file
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 > weekly_summary.md

Release Notes: None
Epic: None
@wenyihu6
Copy link
Copy Markdown
Contributor Author

wenyihu6 commented Jan 6, 2026

Fixed the linter. TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Jan 6, 2026
159819: cmd: add ghsearchdump and ghweeklysummary r=wenyihu6 a=wenyihu6

Epic: none 
Release note: none

---
**ghsearchdump**


---
**cmd/ghweeklysummary: add tool for generating weekly PR summaries**

```
Example usage:

# Last 1 week
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1

# Specific date range
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --after 2025-01-01 --before 2025-02-01

# Save to file
go run ./pkg/cmd/ghweeklysummary --author wenyihu6 > weekly_summary.md
```

Release Notes: None
Epic: None

---
**cmd: move kv dev tools under pkg/cmd/kv/**

Move ghsearchdump and ghweeklysummary under pkg/cmd/kv/ for clearer
ownership. This seems okay given we already have pkg/cmd/allocsim.

```
Example usage:

❯ go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1

❯ go run ./pkg/cmd/kv/ghsearchdump \
  --search "repo:cockroachdb/cockroach author:wenyihu6" \
  --contribution-after 2025-12-12
tracking contributions from: [wenyihu6]
```



160459: kvserver: add tracing to TestStoreRangeSplitBackpressureWrites r=tbg a=stevendanna

In #160141 we observed this test fail. This test is rather stable but does depend on two goroutines sending batches to the KV server within a 100ms timeout. One suspicion is that very rarely we are too slow and this time-based coordination is not enough.

This test is rather stable and adding more sophisticated coordination will further complicate an already complicated test. Here, I add some tracing that will hopefully allow us to confirm the timing based theory if this ever happens again.

Fixes #160141

Release note: None

160499: pgwire: handle negative scale r=drewkimball,yuzefovich a=dils2k

The node could crash if it received a decimal with a negative scale value. This commit adds a check and returns an error instead.

Epic: CRDB-57539
Fixes: #158884

Release note (bug fix): CockroachDB could previously crash when handling decimals with negative scales via extended PGWire protocol and this has been fixed (an error is returned, similar to PG).

160526: sql: fix TestUnsplitRanges to work with external test tenants r=rafiss a=rafiss

Previously, TestUnsplitRanges was skipped in external test tenant mode because it scanned meta ranges directly and performed AdminSplit/ AdminUnsplit operations that external tenants cannot do.

This commit fixes the test by:
1. Using the system layer's DB for meta range operations (scanning meta ranges, checking sticky bits, splitting ranges) since tenants cannot access meta ranges directly.
2. Using the application layer's DB for table data operations which tenants can access.
3. Granting the CanAdminUnsplit capability to the external tenant so the GC job can unsplit ranges after dropping tables/indexes.

Resolves: #142388
Epic: CRDB-48944

Release note: None

Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com>
Co-authored-by: Steven Danna <danna@cockroachlabs.com>
Co-authored-by: dils2k <dils.matchanov@gmail.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 6, 2026

Build failed (retrying...):

@wenyihu6
Copy link
Copy Markdown
Contributor Author

wenyihu6 commented Jan 6, 2026

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 6, 2026

Canceled.

Move ghsearchdump and ghweeklysummary under pkg/cmd/kv/ for clearer
ownership. This seems okay given we already have pkg/cmd/allocsim.

Example usage:

❯ go run ./pkg/cmd/ghweeklysummary --author wenyihu6 --weeks 1

❯ go run ./pkg/cmd/kv/ghsearchdump \
  --search "repo:cockroachdb/cockroach author:wenyihu6" \
  --contribution-after 2025-12-12
tracking contributions from: [wenyihu6]
@wenyihu6
Copy link
Copy Markdown
Contributor Author

wenyihu6 commented Jan 6, 2026

bors r+

@craig craig bot merged commit f50ee9d into cockroachdb:master Jan 6, 2026
26 checks passed
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants