sql: negative scale in pgwire binary decimal format crashes node #158884
Description
With the following test case in TestPGTest:
send
Parse {"Name": "s1", "Query": "SELECT $1::decimal"}
Bind {"DestinationPortal": "p1", "PreparedStatement": "s1", "ParameterFormatCodes": [1], "Parameters": [{"binary":"000100010000FFF00001"}]}
Execute {"Portal": "p1"}
Sync
----
until
ReadyForQuery
----
And running that test against an active CRDB node:
./dev test pkg/sql/pgwire -f TestPGTest/_tmp --test-args "-addr=localhost:26257 -user=root"
You can crash the node with a slice out-of-bounds panic. The crash happens because the decimal decoding logic doesn't know how to handle a negative scale (the FFF0 part).
Jira issue: CRDB-57539
Metadata
Metadata
Assignees
Labels
Semantic compatibility with PostgreSQLCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Likely to be a quick win for someone experienced.Medium-low impact: incurs increased costs for some users (incl lower avail, recoverable bad data)SQL Queries TeamUsed to mark GA and release blockers and technical advisories for 25.4Used to mark GA and release blockers, technical advisories, and bugs for 26.1
Type
Projects
Status