kvserver: better obs in TestTxnReadWithinUncertaintyIntervalAfterRangeMerge#143270
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Mar 26, 2025
Conversation
Member
d81ea55 to
03bf83c
Compare
stevendanna
approved these changes
Mar 24, 2025
…eMerge This is a complex test with a rare failure mode. Trace all of the relevant operations so that we can meaningfully engage with it. Epic: none Release note: none
03bf83c to
ba89df8
Compare
Member
Author
|
bors r+ |
Contributor
Collaborator
|
I have a failure of this test here, is it plausible this PR introduced this failure mode? (I don't see an error like this searching my email) Or if not, is it possible the observability added here allows us to diagnose an issue? |
Member
Author
|
Ugh yeah this definitely explodes because of this PR. Let me revert. |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 26, 2025
…fterRangeMerge" This reverts commit ba89df8. See cockroachdb#143270 (comment) Epic: none Release note: None
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 26, 2025
Fixes cockroachdb#143270, which would previously crash ~immediately under stress. Epic: none Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
143503: sql: remove plan node visitor and observer r=mgartner a=mgartner #### sql: add SetInput method to planNode interface The `SetInput` method has been added to the planNode interface. It will be used in future commits. Release note: None #### sql: use planNode methods to replace unwrapped planNodes The `(*planNodeToRowSource).SetInput` method now uses the `InputCount`, `Input`, and `SetInput` methods of `planNode`, instead of `walkPlan`, to traverse and replace nodes in the plan node tree. This continues the effort to deprecate and remove the plan node walkers (see #137620 for more details on the motivation for this). Release note: None #### sql: use planNode methods to traverse CDC planNodes CDC plan node trees that previously used plan visitors and observers now use the `InputCount`, `Input`, and `SetInput` methods of the `planNode` interface to traverse and manipulate the plan node tree. This continues the effort to deprecate and remove the plan node walkers (see #137620 for more details on the motivation for this). Release note: None #### sql: remove unused planVisitor and planObserver Release note: None #### sql: rename walk.go to plan_names.go This file has been renamed to reflect that it no longer contains any logic for walking plan node trees. It only contains logic related to plan node names. Epic: None Release note: None 143506: explain: fix plan gist decoding with nil catalog r=yuzefovich a=yuzefovich Previously, when catalog wasn't specified during plan gist decoding, we forgot to decode the table ID. This would lead to unexpected remainder of the gist that could result in unexpected behavior, and this is now fixed. Only the "external" variant of decoding is affected, so I decided to not include the release note. Epic: None Release note: None 143515: build: upgrade bazel to 7.6.0 r=rail a=rickystewart 7.2.1 has a remote-execution related bug which should be fixed in this version. Epic: none Release note: None 143522: kvserver: use correct tracer in a test r=rickystewart a=tbg Fixes #143270, which would previously crash ~immediately under stress. Epic: none Release note: None Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 27, 2025
Split out from cockroachdb#143270. Epic: none Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
143240: jsonpath: add `like_regex`, string and null scalars r=normanchenn a=normanchenn #### jsonpath/parser: add support for string scalars This commit adds string scalars, enabling string comparisons within jsonpath queries. Epic: None Release note (sql change): Support string comparisons within jsonpath queries. #### jsonpath/parser: add support for null scalars. This commit adds null scalars, enabling null comparisons within jsonpath queries. Epic: None Release note (sql change): Support null comparisons within jsonpath queries. #### jsonpath: add `like_regex` support This commit add `like_regex` predicate evaluation support. Flags for `like_regex` are not supported yet. Informs: #143243 Epic: None Release note (sql change): Add `like_regex` predicate evaluation support for jsonpath queries. Flags for `like_regex` are not supported yet. 143507: roachpb: print observed timestamps in txn r=tbg a=tbg Split out from #143270. Epic: none Release note: None 143516: ui: bump cluster-ui to 25.2.0-prerelease.0 r=kyle-a-wong a=kyle-a-wong Resolves: https://cockroachlabs.atlassian.net/browse/CC-31786 Release note: None Co-authored-by: Norman Chen <norman.chen@cockroachlabs.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Kyle Wong <37189875+kyle-a-wong@users.noreply.github.com>
spilchen
pushed a commit
to spilchen/cockroach
that referenced
this pull request
Mar 27, 2025
Split out from cockroachdb#143270. Epic: none Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143260.
This is a complex test with a rare failure mode. Trace all of the relevant operations so that we can meaningfully engage with it.
Epic: none
Release note: none