explain: fix plan gist decoding with nil catalog#143506
explain: fix plan gist decoding with nil catalog#143506craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, when catalog wasn't specified during plan gist decoding, we forgot to decode the table ID. This would lead to unexpected remainder of the gist that could result in unexpected behavior, and this is now fixed. Only the "external" variant of decoding is affected, so I decided to not include the release note. Release note: None
|
This change is |
mgartner
left a comment
There was a problem hiding this comment.
Nice find!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
|
(The reason I added the backport label is that I've seen in CI that this bug could cause fatal crashes that are not caught by the panic catcher.) |
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from fbd8038 to blathers/backport-release-23.2-143506: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-23.2 failed. See errors above. error creating merge commit from fbd8038 to blathers/backport-release-24.1-143506: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-24.1 failed. See errors above. error creating merge commit from fbd8038 to blathers/backport-release-24.3-143506: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-24.3 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously, when catalog wasn't specified during plan gist decoding, we forgot to decode the table ID. This would lead to unexpected remainder of the gist that could result in unexpected behavior, and this is now fixed. Only the "external" variant of decoding is affected, so I decided to not include the release note.
Epic: None
Release note: None