sql: remove plan node visitor and observer#143503
Merged
craig[bot] merged 5 commits intocockroachdb:masterfrom Mar 26, 2025
Merged
sql: remove plan node visitor and observer#143503craig[bot] merged 5 commits intocockroachdb:masterfrom
craig[bot] merged 5 commits intocockroachdb:masterfrom
Conversation
The `SetInput` method has been added to the planNode interface. It will be used in future commits. Release note: None
The `(*planNodeToRowSource).SetInput` method now uses the `InputCount`, `Input`, and `SetInput` methods of `planNode`, instead of `walkPlan`, to traverse and replace nodes in the plan node tree. This continues the effort to deprecate and remove the plan node walkers (see cockroachdb#137620 for more details on the motivation for this). Release note: None
CDC plan node trees that previously used plan visitors and observers now use the `InputCount`, `Input`, and `SetInput` methods of the `planNode` interface to traverse and manipulate the plan node tree. This continues the effort to deprecate and remove the plan node walkers (see cockroachdb#137620 for more details on the motivation for this). Release note: None
Release note: None
This file has been renamed to reflect that it no longer contains any logic for walking plan node trees. It only contains logic related to plan node names. Release note: None
Member
|
This change is |
yuzefovich
approved these changes
Mar 26, 2025
Member
yuzefovich
left a comment
There was a problem hiding this comment.
🎉
Reviewed 8 of 8 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, 1 of 1 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andyyang890)
Contributor
Author
|
Thanks for being my review partner on this journey @yuzefovich! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql: add SetInput method to planNode interface
The
SetInputmethod has been added to the planNode interface. It willbe used in future commits.
Release note: None
sql: use planNode methods to replace unwrapped planNodes
The
(*planNodeToRowSource).SetInputmethod now uses theInputCount,Input, andSetInputmethods ofplanNode, instead ofwalkPlan, totraverse and replace nodes in the plan node tree. This continues the
effort to deprecate and remove the plan node walkers (see #137620 for
more details on the motivation for this).
Release note: None
sql: use planNode methods to traverse CDC planNodes
CDC plan node trees that previously used plan visitors and observers now
use the
InputCount,Input, andSetInputmethods of theplanNodeinterface to traverse and manipulate the plan node tree. This continues
the effort to deprecate and remove the plan node walkers (see #137620
for more details on the motivation for this).
Release note: None
sql: remove unused planVisitor and planObserver
Release note: None
sql: rename walk.go to plan_names.go
This file has been renamed to reflect that it no longer contains any
logic for walking plan node trees. It only contains logic related to
plan node names.
Epic: None
Release note: None