schemachanger: remove RBR fallback for drop column#142921
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 17, 2025
Merged
schemachanger: remove RBR fallback for drop column#142921craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
9cf17fa to
7f31f02
Compare
Also add testing to make sure the subzones are updated after the primary index swap. Epic CRDB-31462 Release note: None
fqazi
approved these changes
Mar 17, 2025
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
@rafiss Nice work, and happy this limitation is finally being lifted. All the plans look good too!
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Collaborator
Author
|
tftr! i think we also should be able to get CREATE INDEX to work now as well 🚀 bors r+ |
Contributor
annrpom
added a commit
to annrpom/cockroach
that referenced
this pull request
Mar 26, 2025
The end to end tests with DML injections we added in cockroachdb#140617, cockroachdb#139622, cockroachdb#142921 are sufficient. Epic: none Fixes: cockroachdb#136846 Release note: None
spilchen
pushed a commit
to spilchen/cockroach
that referenced
this pull request
Mar 27, 2025
The end to end tests with DML injections we added in cockroachdb#140617, cockroachdb#139622, cockroachdb#142921 are sufficient. Epic: none Fixes: cockroachdb#136846 Release note: None
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add testing to make sure the subzones are updated after the primary
index swap.
Epic CRDB-31462
Release note: None