testutilsccl: only test legacy in AlterPrimaryKeyCorrectZoneConfigTest#143545
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 27, 2025
Merged
testutilsccl: only test legacy in AlterPrimaryKeyCorrectZoneConfigTest#143545craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The end to end tests with DML injections we added in cockroachdb#140617, cockroachdb#139622, cockroachdb#142921 are sufficient. Epic: none Fixes: cockroachdb#136846 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
spilchen
approved these changes
Mar 27, 2025
Contributor
spilchen
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @annrpom)
Contributor
Author
|
TFTR! ('-')7 bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end to end tests with DML injections we added
in #140617, #139622, #142921 are sufficient.
Epic: none
Fixes: #136846
Release note: None