schemachanger: remove regional-by-row fallback for CREATE INDEX#139622
schemachanger: remove regional-by-row fallback for CREATE INDEX#139622craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
ff71858 to
472a0d8
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
9d34dc5 to
857bf2b
Compare
fqazi
left a comment
There was a problem hiding this comment.
Nice! Just one suggestion for DML injection
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
pkg/ccl/schemachangerccl/testdata/end_to_end/create_index_regional_by_row/create_index_regional_by_row.definition line 9 at r1 (raw file):
---- stage-exec phase=PostCommitPhase stage=:
We probably also want inserts on the non-reveritble part of the plan
This is easy to support, since all the required functionality was added when we added support for regional-by-row tables for ADD/DROP COLUMN. Release note: None
857bf2b to
7e07a71
Compare
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/schemachangerccl/testdata/end_to_end/create_index_regional_by_row/create_index_regional_by_row.definition line 9 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
We probably also want inserts on the non-reveritble part of the plan
Done.
|
tftr! bors r+ |
The end to end tests with DML injections we added in cockroachdb#140617, cockroachdb#139622, cockroachdb#142921 are sufficient. Epic: none Fixes: cockroachdb#136846 Release note: None
The end to end tests with DML injections we added in cockroachdb#140617, cockroachdb#139622, cockroachdb#142921 are sufficient. Epic: none Fixes: cockroachdb#136846 Release note: None
This is easy to support, since all the required functionality was added
when we added support for regional-by-row tables for ADD/DROP COLUMN.
Epic: CRDB-31329
Release note: None