Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.1
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.2
Choose a head ref
  • 5 commits
  • 7 files changed
  • 3 contributors

Commits on Nov 24, 2022

  1. chore: Run benchmarks in CI (#425)

    Adds a Github Action step to run benchmarks in CI and report on the differences with `main`.
    
    It uses a combination of [gobenchdata](https://github.com/bobheadxi/gobenchdata), the [netlify/delta-action](https://github.com/netlify/delta-action) and a simple Go script to glue them together.
    
    Example from lower down in this PR:
    ![Screenshot 2022-11-22 at 18 56 21](https://user-images.githubusercontent.com/1121616/203398189-b8a0b94c-bb1b-416d-94d4-84cf71feb176.png)
    
    Closes #424
    hermanschaaf authored Nov 24, 2022
    1 Configuration menu
    Copy the full SHA
    9882458 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. chore: Use GH_CQ_BOT token to comment on Benchmark results (#436)

    We need slightly elevated permissions to make a comment when the PR
    comes from a fork, and I believe this should do the trick.
    
    Github Actions security when it comes to external PRs is a bit of a
    minefield, but because we're avoiding the `pull_request_target` trigger
    here, and not running any repository code in the delta-action itself, I
    believe this is safe.
    
    This should fix the issue we're seeing here
    #430
    hermanschaaf authored Nov 25, 2022
    1 Configuration menu
    Copy the full SHA
    178c32e View commit details
    Browse the repository at this point in the history
  2. chore: Remove benchmark comments for now (#437)

    The fix in #436 didn't
    work; looks like you can't use the GH bot token from a forked repo PR
    either.
    hermanschaaf authored Nov 25, 2022
    Configuration menu
    Copy the full SHA
    c1cc6e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ffffcd5 View commit details
    Browse the repository at this point in the history
  4. chore(main): Release v1.8.2 (#438)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [1.8.2](v1.8.1...v1.8.2)
    (2022-11-25)
    
    
    ### Bug Fixes
    
    * **test:** Values check test should account for `IgnoreInTests` column
    option ([#431](#431))
    ([ffffcd5](ffffcd5))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Nov 25, 2022
    Configuration menu
    Copy the full SHA
    04a336e View commit details
    Browse the repository at this point in the history
Loading