chore: Use GH_CQ_BOT token to comment on Benchmark results#436
Merged
hermanschaaf merged 2 commits intomainfrom Nov 25, 2022
Merged
chore: Use GH_CQ_BOT token to comment on Benchmark results#436hermanschaaf merged 2 commits intomainfrom
hermanschaaf merged 2 commits intomainfrom
Conversation
Contributor
⏱️ Benchmark resultsComparing with 9882458
|
hermanschaaf
commented
Nov 25, 2022
| run: make benchmark-ci | ||
| - name: Delta | ||
| uses: hermanschaaf/delta-action@v1.0.7 | ||
| uses: netlify/delta-action@v4.1.0 |
Contributor
Author
There was a problem hiding this comment.
Also changed back to the upstream version now that my PR got merged in there
hermanschaaf
added a commit
that referenced
this pull request
Nov 25, 2022
The fix in #436 didn't work; looks like you can't use the GH bot token from a forked repo PR either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need slightly elevated permissions to make a comment when the PR comes from a fork, and I believe this should do the trick.
Github Actions security when it comes to external PRs is a bit of a minefield, but because we're avoiding the
pull_request_targettrigger here, and not running any repository code in the delta-action itself, I believe this is safe.This should fix the issue we're seeing here #430