chore: Remove benchmark comments for now#437
Merged
hermanschaaf merged 1 commit intomainfrom Nov 25, 2022
Merged
Conversation
yevgenypats
approved these changes
Nov 25, 2022
|
One solution could be to do what we (netlify) do here in this repo. It is a little bit complicated for what it does in the end but it works. It calculates the delta and uploads it, then uses the workflow_run event and posts the comment. |
Member
|
Thanks @danez, that should work well for us 🥇 |
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
Brings back the benchmark comment based on #437 (comment) This should only start working post merge (I hope) as the workflow file needs to be on the `main` branch ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #436 didn't work; looks like you can't use the GH bot token from a forked repo PR either.