Skip to content

fix: Upgrade schema in history mode#494

Merged
roneli merged 4 commits intocloudquery:mainfrom
disq:fix/upgrade-history
Feb 17, 2022
Merged

fix: Upgrade schema in history mode#494
roneli merged 4 commits intocloudquery:mainfrom
disq:fix/upgrade-history

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Feb 17, 2022

Views need to be dropped before any migrations can be applied (except creating new tables)

@disq disq requested a review from roneli February 17, 2022 10:29
@github-actions github-actions bot added the fix label Feb 17, 2022
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add a test for this? upgrade -> works -> downgrade -> works -> upgrade -> works ?

Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit d1e49ad into cloudquery:main Feb 17, 2022
@disq disq deleted the fix/upgrade-history branch February 17, 2022 15:49
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Feb 22, 2022
* upstream/main:
  feat: Policy Snapshot Testing (cloudquery#449)
  fix: Remove enable_partial_fetch and support for migrationless providers (cloudquery#495)
  fix: Upgrade schema in history mode (cloudquery#494)
  fix: Don't report unmanaged provider diags to sentry (cloudquery#492)
  feat: Modules v2 support (cloudquery#489)
  chore: Synced local '.github/dependabot.yml' with remote 'dependabot.yml' (cloudquery#490)
  chore: Remove '--debug' flag from issue template (cloudquery#488)
  fix: Don't return an error if encountering an empty subpolicy (cloudquery#486)
  fix: Fetch summary SQL state 54000 (cloudquery#487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants