fix: Don't return an error if encountering an empty subpolicy#486
Merged
roneli merged 1 commit intocloudquery:mainfrom Feb 14, 2022
shimonp21:smallfix
Merged
fix: Don't return an error if encountering an empty subpolicy#486roneli merged 1 commit intocloudquery:mainfrom shimonp21:smallfix
roneli merged 1 commit intocloudquery:mainfrom
shimonp21:smallfix
Conversation
roneli
suggested changes
Feb 11, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Looks good, have a minor suggestion.
Also removed the "multilayer policies with invalid selector" test (since now, the "executor" won't actually return an error in the "invalid selector" case - it will be up to the "manager").
roneli
approved these changes
Feb 14, 2022
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Feb 22, 2022
…uery#486) Also removed the "multilayer policies with invalid selector" test (since now, the "executor" won't actually return an error in the "invalid selector" case - it will be up to the "manager").
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Feb 22, 2022
* upstream/main: feat: Policy Snapshot Testing (cloudquery#449) fix: Remove enable_partial_fetch and support for migrationless providers (cloudquery#495) fix: Upgrade schema in history mode (cloudquery#494) fix: Don't report unmanaged provider diags to sentry (cloudquery#492) feat: Modules v2 support (cloudquery#489) chore: Synced local '.github/dependabot.yml' with remote 'dependabot.yml' (cloudquery#490) chore: Remove '--debug' flag from issue template (cloudquery#488) fix: Don't return an error if encountering an empty subpolicy (cloudquery#486) fix: Fetch summary SQL state 54000 (cloudquery#487)
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed the "multilayer policies with invalid selector" test (since now,
the "executor" won't actually return an error in the "invalid selector" case - it
will be up to the "manager").