Merged
Conversation
roneli
suggested changes
Feb 15, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Comments on modules v2 support
roneli
reviewed
Feb 15, 2022
pkg/module/manager.go
Outdated
Comment on lines
+164
to
+182
| if l := len(unsupportingProviders); l == 1 { | ||
| return 0, nil, fmt.Errorf("provider %s doesn't support %s yet", unsupportingProviders[0], mod.ID()) | ||
| } else if l > 1 { | ||
| return 0, nil, fmt.Errorf("providers %s don't support %s yet", strings.Join(unsupportingProviders, ", "), mod.ID()) | ||
| } | ||
|
|
||
| if l := len(olderProviders); l == 1 { | ||
| return 0, nil, fmt.Errorf("provider %s seems to support an older version of %s, which is incompatible with your cloudquery version", olderProviders[0], mod.ID()) | ||
| } else if l > 1 { | ||
| return 0, nil, fmt.Errorf("providers %s seem to support an older version of %s, which is incompatible with your cloudquery version", strings.Join(olderProviders, ", "), mod.ID()) | ||
| } | ||
|
|
||
| if l := len(newerProviders); l == 1 { | ||
| return 0, nil, fmt.Errorf("provider %s seems to support a newer version of %s, which is incompatible with your cloudquery version", newerProviders[0], mod.ID()) | ||
| } else if l > 1 { | ||
| return 0, nil, fmt.Errorf("providers %s seem to support a newer version of %s, which is incompatible with your cloudquery version", strings.Join(newerProviders, ", "), mod.ID()) | ||
| } | ||
|
|
||
| return 0, nil, fmt.Errorf("version mismatch between module and providers, please upgrade your providers and/or cloudquery") |
Contributor
There was a problem hiding this comment.
nit: put this in a function?
Member
Author
There was a problem hiding this comment.
done, simplified and added test
a869582 to
527ded2
Compare
roneli
approved these changes
Feb 16, 2022
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Feb 22, 2022
* upstream/main: feat: Policy Snapshot Testing (cloudquery#449) fix: Remove enable_partial_fetch and support for migrationless providers (cloudquery#495) fix: Upgrade schema in history mode (cloudquery#494) fix: Don't report unmanaged provider diags to sentry (cloudquery#492) feat: Modules v2 support (cloudquery#489) chore: Synced local '.github/dependabot.yml' with remote 'dependabot.yml' (cloudquery#490) chore: Remove '--debug' flag from issue template (cloudquery#488) fix: Don't return an error if encountering an empty subpolicy (cloudquery#486) fix: Fetch summary SQL state 54000 (cloudquery#487)
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.