internal/exec/terraform_query_test.go (1)

17-66: Consider consolidating these auth-manager scenarios into a table-driven test.

The three createQueryAuthManager tests follow the same setup/assert structure and can be compacted into a single table-driven case matrix for maintainability.

As per coding guidelines: Use table-driven tests for testing multiple scenarios in Go.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/exec/terraform_query_test.go` around lines 17 - 66, Consolidate the
three tests for createQueryAuthManager
(TestCreateQueryAuthManager_NoAuthConfigured,
TestCreateQueryAuthManager_ErrorReturned,
TestCreateQueryAuthManager_EmptyIdentity) into a single table-driven test:
define a slice of test cases with fields like name, info
(*schema.ConfigAndStacksInfo), atmosConfig (*schema.AtmosConfiguration), wantErr
(bool), wantErrIs (error or nil), and wantAuthNil (bool); iterate over cases
with t.Run(tc.name, func(t *testing.T) { authManager, err :=
createQueryAuthManager(tc.info, tc.atmosConfig); assert conditions using
tc.wantErr, assert.ErrorIs for tc.wantErrIs when non-nil, and
assert.Nil/assert.NotNil on authManager and tc.info.AuthManager per
tc.wantAuthNil }); keep each case setup minimal (use t.TempDir for BasePath) and
preserve the original expectations (ErrAuthNotConfigured for the error case).

internal/exec/terraform_query.go (1)

17-22: Prefer injected dependencies over a package-global factory hook.

This works, but a mutable package-global test hook can make test isolation brittle over time. A small injected dependency container for query execution would keep the same testability without shared global state.

♻️ Optional refactor sketch

+type terraformQueryDeps struct {
+	createAuthManager func(identity string, authConfig schema.AuthConfig, flagSelectValue string, atmosConfig *schema.AtmosConfiguration) (auth.AuthManager, error)
+}
+
+var defaultTerraformQueryDeps = terraformQueryDeps{
+	createAuthManager: func(identity string, authConfig schema.AuthConfig, flagSelectValue string, atmosConfig *schema.AtmosConfiguration) (auth.AuthManager, error) {
+		mergedAuthConfig := auth.CopyGlobalAuthConfig(&authConfig)
+		return auth.CreateAndAuthenticateManagerWithAtmosConfig(identity, mergedAuthConfig, flagSelectValue, atmosConfig)
+	},
+}

As per coding guidelines: Use interfaces for external dependencies to facilitate mocking and consider using testify/mock for creating mock implementations.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/exec/terraform_query.go` around lines 17 - 22, Replace the mutable
package-global test hook authManagerFactory with an injected dependency: add an
interface (e.g., AuthManagerFactory with a Create(identity, authConfig,
flagSelectValue, atmosConfig) method) and accept an implementation via the
constructor or as a field on the query executor type that currently uses
authManagerFactory; update all call sites to use the injected factory instead of
the package variable and provide a mock implementation in tests (use
testify/mock or a simple stub) that delegates to
auth.CreateAndAuthenticateManagerWithAtmosConfig for production. Ensure the new
interface name and method map to authManagerFactory's signature so callers like
CreateAndAuthenticateManagerWithAtmosConfig are easy to replace in tests.