Skip to content

Exclude unsupported windows/arm from goreleaser build matrix#2133

Merged
aknysh merged 2 commits intomainfrom
goruha/update-goreleaser
Mar 3, 2026
Merged

Exclude unsupported windows/arm from goreleaser build matrix#2133
aknysh merged 2 commits intomainfrom
goruha/update-goreleaser

Conversation

@goruha
Copy link
Member

@goruha goruha commented Mar 3, 2026 •
edited by coderabbitai bot
Loading

what

  • Add ignore rule to the shared goreleaser config (.github/goreleaser.yml) to exclude the windows/arm (32-bit ARM) build target
  • Prevents "unsupported GOOS/GOARCH pair windows/arm" build failures for any org repo using Go 1.24+

why

  • Go 1.24 (February 2025) deprecated the windows/arm port, and Go 1.25+ removed it entirely. Any repo that upgrades past Go 1.23 and uses this shared goreleaser config will fail during the release build after spending ~33 minutes compiling the other 13 targets
  • The ignore rule is harmless for repos still on Go < 1.24 — goreleaser simply skips a target that would otherwise build successfully. No binaries are lost for any currently-supported platform
  • windows/arm (32-bit ARM on Windows) had negligible real-world usage — Windows on ARM devices run 64-bit Windows 11 (windows/arm64), which remains supported

references

Summary by CodeRabbit

  • Chores
    • Excluded Windows ARM 32-bit builds from release distribution.

@goruha goruha requested a review from a team as a code owner March 3, 2026 19:00
@github-actions github-actions bot added the size/xs Extra small size PR label Mar 3, 2026
@mergify mergify bot added the triage Needs triage label Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@mergify mergify bot removed the triage Needs triage label Mar 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8e95b5b and aac6f7f.

📒 Files selected for processing (1)
  • .goreleaser.yml
📝 Walkthrough

Walkthrough

The PR adds an ignore configuration to .goreleaser.yml to exclude Windows ARM 32-bit builds from release artifacts, addressing Go 1.24+ dropping support for this platform combination.

Changes

Cohort / File(s) Summary
GoReleaser Build Configuration
.goreleaser.yml		 Added ignore section under builds to explicitly exclude Windows on ARM (32-bit) targets from release builds due to Go 1.24+ platform support changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

patch

Suggested reviewers

  • osterman
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: excluding the unsupported windows/arm target from the GoReleaser build matrix, matching the core objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch goruha/update-goreleaser

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aknysh aknysh added the no-release Do not create a new release (wait for additional code changes) label Mar 3, 2026
@aknysh aknysh merged commit 53d7820 into main Mar 3, 2026
130 of 141 checks passed
@aknysh aknysh deleted the goruha/update-goreleaser branch March 3, 2026 20:22
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.55%. Comparing base (8e95b5b) to head (aac6f7f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2133   +/-   ##
=======================================
  Coverage   76.54%   76.55%           
=======================================
  Files         832      832           
  Lines       79458    79458           
=======================================
+ Hits        60824    60830    +6     
+ Misses      14841    14836    -5     
+ Partials     3793     3792    -1
Flag Coverage Δ
unittests 76.55% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

These changes were released in v1.208.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milldr milldr milldr approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

no-release Do not create a new release (wait for additional code changes) size/xs Extra small size PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goruha @milldr @aknysh