Skip to content

Split go release config#1355

Merged
goruha merged 3 commits intomainfrom
split-go-release-config
Jun 25, 2025
Merged

Split go release config#1355
goruha merged 3 commits intomainfrom
split-go-release-config

Conversation

@goruha
Copy link
Member

@goruha goruha commented Jun 25, 2025 •
edited by coderabbitai bot
Loading

what

  • Split the go releaser config

why

  • Support a separate config for draft releases

Summary by CodeRabbit

  • Chores
    • Introduced a new configuration file to automate build and release processes for multiple platforms.
    • Updated build settings to consistently include all supported operating systems and architectures, regardless of environment variables.

@goruha goruha requested a review from a team as a code owner June 25, 2025 19:38
@github-actions github-actions bot added the size/s Small size PR label Jun 25, 2025
@goruha goruha added patch A minor, backward compatible change labels Jun 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 25, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

A new GoReleaser configuration file for draft releases is added, and the main GoReleaser configuration is updated to always build for all supported OS and architecture combinations, removing conditional logic based on an environment variable. The draft config targets only Linux and Darwin and creates draft GitHub releases.

Changes

File(s) Change Summary
.goreleaser.draft.yml Added new GoReleaser config for draft releases: builds for Linux/Darwin (amd64, arm64), disables CGO, drafts GitHub release
.goreleaser.yml Simplified build matrix: always builds for all OS (linux, darwin, freebsd, windows) and architectures (amd64, arm64, 386, arm); removed conditional logic

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GoReleaser
    participant GitHub

    Developer->>GoReleaser: Trigger release (using .goreleaser.yml or .goreleaser.draft.yml)
    GoReleaser->>GoReleaser: Build binaries for specified OS/Arch
    GoReleaser->>GoReleaser: Generate archives and checksums
    GoReleaser->>GitHub: Create (draft) release and upload artifacts
Loading

Possibly related PRs

Suggested labels

minor

Suggested reviewers

  • aknysh
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch split-go-release-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @auto-summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @auto-title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
.goreleaser.yml (1)

40-44: release.draft: true here collides with the new draft-specific file.

With this flag present, every build that uses .goreleaser.yml will stay in draft mode, so the separate .goreleaser.draft.yml adds no behavioral difference.

-  draft: true
+  draft: false            # publish real releases; drafts handled in .goreleaser.draft.yml
🧹 Nitpick comments (3)
.goreleaser.yml (1)

18-18: Trailing whitespace sneaked in.

-      - 'arm'␠
+      - 'arm'
.goreleaser.draft.yml (2)

16-16: Trim trailing space.

-      - 'amd64'␠
+      - 'amd64'

43-43: Trailing space here too.

-  prerelease: auto ␠
+  prerelease: auto
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70990a6 and 00ccb4c.

📒 Files selected for processing (2)
  • .goreleaser.draft.yml (1 hunks)
  • .goreleaser.yml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.goreleaser.draft.yml

[error] 16-16: trailing spaces

(trailing-spaces)

[error] 43-43: trailing spaces

(trailing-spaces)

.goreleaser.yml

[error] 18-18: trailing spaces

(trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build (windows-latest, windows)
  • GitHub Check: Summary
🔇 Additional comments (1)
.goreleaser.yml (1)

13-22: Full build-matrix looks good, but double-check exotic pairs.

windows/arm and freebsd/arm still fail on some older Go toolchains & runners. If CI images lag, the whole release can bomb out.

A quick smoke-test matrix run or a selective exclude list can save the day.

@codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.38%. Comparing base (70990a6) to head (00ccb4c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
+ Coverage   51.32%   51.38%   +0.06%     
==========================================
  Files         243      243              
  Lines       26230    26230              
==========================================
+ Hits        13462    13479      +17     
+ Misses      11102    11082      -20     
- Partials     1666     1669       +3
Flag Coverage Δ
unittests 51.38% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@goruha goruha merged commit e4ff11c into main Jun 25, 2025
82 of 83 checks passed
@goruha goruha deleted the split-go-release-config branch June 25, 2025 20:18
@coderabbitai coderabbitai bot mentioned this pull request Mar 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osterman osterman osterman approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

patch A minor, backward compatible change size/s Small size PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goruha @osterman