Skip to content

Fix go releaser templating#1354

Merged
goruha merged 1 commit intomainfrom
fix-go-releaser-templating
Jun 25, 2025
Merged

Fix go releaser templating#1354
goruha merged 1 commit intomainfrom
fix-go-releaser-templating

Conversation

@goruha
Copy link
Member

@goruha goruha commented Jun 25, 2025

what

  • Fix go releaser templating

Summary by CodeRabbit

  • Refactor
    • Simplified and streamlined the build configuration for supported operating systems and architectures, resulting in a more concise and maintainable setup. This may affect which platforms receive builds in certain draft modes.

@goruha goruha requested a review from a team as a code owner June 25, 2025 18:16
@github-actions github-actions bot added the size/s Small size PR label Jun 25, 2025
@goruha goruha added the patch A minor, backward compatible change label Jun 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

📝 Walkthrough

Walkthrough

The .goreleaser.yml build configuration was refactored to simplify how target operating systems and architectures are selected. The logic now uses inline array expressions with a single conditional check on GO_RELEASER_DRAFT_MODE, removing previous multiline conditional blocks and no longer referencing GO_RELEASER_TARGET_COMMITISH.

Changes

File(s) Change Summary
.goreleaser.yml Refactored build target selection: replaced multiline conditionals with inline arrays and a single environment variable check.

Possibly related PRs

Suggested labels

patch

Suggested reviewers

  • aknysh
  • osterman
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch fix-go-releaser-templating

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @auto-summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @auto-title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48608f0 and 5efa520.

📒 Files selected for processing (1)
  • .goreleaser.yml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.goreleaser.yml

[error] 13-13: syntax error: expected ',' or ']', but got '{'

(syntax)

⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: PR Size Labeler
  • GitHub Check: Lint (golangci)
  • GitHub Check: prepare
  • GitHub Check: Build (windows-latest, windows)
  • GitHub Check: Lint (golangci)
  • GitHub Check: Analyze (go)
  • GitHub Check: Summary

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@48608f0). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage        ?   51.39%           
=======================================
  Files           ?      243           
  Lines           ?    26230           
  Branches        ?        0           
=======================================
  Hits            ?    13480           
  Misses          ?    11081           
  Partials        ?     1669           
Flag Coverage Δ
unittests 51.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@goruha goruha merged commit 70990a6 into main Jun 25, 2025
61 of 62 checks passed
@goruha goruha deleted the fix-go-releaser-templating branch June 25, 2025 19:04
@coderabbitai coderabbitai bot mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch A minor, backward compatible change size/s Small size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants