fix: Add retry and missing workflow step properties to all schema copies#2113
fix: Add retry and missing workflow step properties to all schema copies#2113
Conversation
…w step schema Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
|
@copilot I believe there are 3 schemas where this may need to be updated. Can you double check? |
…operties Extended schema updates to all atmos-manifest.json files: - pkg/datafetcher/schema/atmos/manifest/1.0.json (embedded schema) - tests/fixtures/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json - examples/demo-localstack/schemas/atmos-manifest.json - examples/demo-context/schemas/atmos-manifest.json - examples/demo-helmfile/schemas/atmos-manifest.json All 6 schemas now include retry, working_directory, identity, and env properties for workflow steps. Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
You're absolutely right! I found and updated all 6 schema locations:
All schemas now include the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 76.53% 76.55% +0.02%
==========================================
Files 832 832
Lines 79458 79458
==========================================
+ Hits 60810 60827 +17
+ Misses 14854 14836 -18
- Partials 3794 3795 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
💥 This pull request now has conflicts. Could you fix it @Copilot? 🙏 |
Resolved conflicts in 2 schema files (website/static and tests/fixtures) where main added workflow_retry $ref while PR added inline retry + 3 other properties. Resolution: keep main's $ref for retry, add PR's working_directory, identity, and env properties. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
These changes were released in v1.208.0. |
…raform-plan * osterman/native-ci-terraform: (28 commits) feat: Add source cache TTL for JIT-vendored components (#2138) feat: Per-target version overrides in vendor manifests (#2141) docs: Add PRD for browser-based auth in aws/user identity (#1887) docs: Add EKS kubeconfig authentication integration PRD (#1884) fix: correct marketplace.json schema and update docs with install/uninstall commands (#2142) fix: propagate auth to all YAML functions in multi-component execution (#2140) fix: Use atmos_component for source provisioner workdir paths (#2137) Fix identity prompts to respect --interactive flag (#2130) Increase PR size thresholds to accommodate AI-assisted development (#2136) docs: Add Azure authentication provider documentation (#2132) fix: propagate component-type level dependencies through stack processor (#2127) fix: Add retry and missing workflow step properties to all schema copies (#2113) Exclude unsupported windows/arm from goreleaser build matrix (#2133) Add AI Agent Skills for LLM-Powered Infrastructure Development (#2121) Fix: Convert toolchain paths to absolute in PATH to resolve exec.LookPath failures (#2095) Fix workdir collision for component instances sharing base component (#2093) fix(auth): propagate TTY state to subprocesses for SSO device flow in workflows (#2126) fix(security): prevent SSRF in GitHub OIDC token URL handling (CWE-918) (#2106) Fix #2112: add workflow_retry definition and retry property to workflow step schema (#2114) fix(auth): auto-detect GitHub Actions WIF with proper audience, host validation, and lazy GSM init (#2109) ...
|
These changes were released in v1.208.1-test.9. |
|
These changes were released in v1.208.1-test.10. |
Schema validation rejected
retryfield in workflow steps despite Go code supporting it since the feature was added. Users hitting validation errors when usingretrywith YAML anchors or inline configuration.Changes
Added missing workflow step properties to all 6 atmos-manifest schema copies in the repository:
website/static/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json(public schema)pkg/datafetcher/schema/atmos/manifest/1.0.json(embedded schema - compiled into binary)tests/fixtures/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json(test fixtures)examples/demo-localstack/schemas/atmos-manifest.jsonexamples/demo-context/schemas/atmos-manifest.jsonexamples/demo-helmfile/schemas/atmos-manifest.jsonProperties added to workflow step definitions:
retry- FullRetryConfigspec withmax_attempts,initial_delay,max_delay,backoff_strategy,multiplier,random_jitter,max_elapsed_timeworking_directory- Step-level working directory overrideidentity- Authentication identity for step executionenv- Step-level environment variablesAll properties support
!includedirective and follow existing schema patterns (e.g.,source_retry).Example
Previously failed with
additionalProperties 'retry' not allowed. Now validates correctly across all schema copies including the embedded schema used at runtime.Original prompt
This section details on the original issue you should resolve
<issue_title>Schema: error with schema not recognizing
retryin workflows</issue_title><issue_description>### Describe the Bug
Added
retryto the workflows properties to out workflows and now atmos describe breaksExpected Behavior
Retry should be added to schema so atmos doesn't blow up
Steps to Reproduce