Skip to content

chore(deps): bump golang.org/x/net from 0.54.0 to 0.55.0#13510

Merged
BagToad merged 1 commit into
trunkfrom
bagtoad/bump-x-net-0-55-0
May 24, 2026
Merged

chore(deps): bump golang.org/x/net from 0.54.0 to 0.55.0#13510
BagToad merged 1 commit into
trunkfrom
bagtoad/bump-x-net-0-55-0

Conversation

@BagToad

@BagToad BagToad commented May 24, 2026

Copy link
Copy Markdown
Member

Upgraded golang.org/x/net from version v0.54.0 to v0.55.0

@BagToad BagToad force-pushed the bagtoad/bump-x-net-0-55-0 branch from 61ee7cd to c049968 Compare May 24, 2026 16:21
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BagToad BagToad force-pushed the bagtoad/bump-x-net-0-55-0 branch from c049968 to be4ad7e Compare May 24, 2026 16:21
@BagToad BagToad marked this pull request as ready for review May 24, 2026 16:22
@BagToad BagToad requested a review from a team as a code owner May 24, 2026 16:22
@BagToad BagToad requested review from babakks and Copilot May 24, 2026 16:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the indirect Go dependency golang.org/x/net to the next patch/minor release.

Changes:

  • Bump golang.org/x/net from v0.54.0 to v0.55.0 in go.mod
  • Update go.sum entries to match the new module version and checksums
Show a summary per file
File Description
go.mod Updates the indirect requirement for golang.org/x/net to v0.55.0.
go.sum Replaces the v0.54.0 checksums with v0.55.0 checksums for golang.org/x/net.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/2 changed files
  • Comments generated: 0

@BagToad BagToad merged commit d2006fe into trunk May 24, 2026
19 checks passed
@BagToad BagToad deleted the bagtoad/bump-x-net-0-55-0 branch May 24, 2026 19:10
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request May 28, 2026
The previous prompt let Claude judge whether a Before/After comparison
was useful and return NONE for "trivial" PRs (dep bumps, refactors,
docs). That cost reviewers a useful framing more often than it saved
them clutter.

New prompt requires both BEFORE and AFTER for every PR, with explicit
guidance for each kind:
  - Bug fix → symptom vs. fixed behavior
  - Feature → couldn't do X vs. can do X
  - Refactor → old impl vs. new impl, same behavior
  - Dep bump → old version vs. new version + reason
  - Docs → before missing / after documented
  - Tests-only → behavior was untested vs. now covered

Even trivial PRs get a modest but real comparison ("typo in error
message" → "typo fixed"). The reviewer can fold the section away with
the existing ▾ Before / After chevron if they don't want to see it.

Verified on cli/cli#13510 (dep bump that previously returned NONE):
  BEFORE: project depends on `golang.org/x/net v0.54.0` (indirect).
  AFTER:  project depends on `golang.org/x/net v0.55.0` (indirect).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 3, 2026
Left rail couldn't scroll (tall content unreachable) and there was no easy
way to hide parts to focus on the files + code.

- Single scroll rail: .rail-scroll (flex:1, overflow-y:auto) holds the three
  sections at natural height; ReviewFooter stays pinned below. Dropped the
  per-pane 50vh internal scrolls (no more nested scrollbars).
- Collapsible sections via a shared RailSectionHead (chevron + title, optional
  right slot): 📌 Summary, 💡 Insights (tabs), 🗂 Files (reviewed count in the
  right slot). Each collapses to a slim header; state persists per section
  (summaryCollapsed / tldrCollapsed / filesCollapsed) so 'collapse Summary +
  Insights to scan files + code' survives reload.
- Removed TLDRResizer + tldrHeight pref and the TL;DR ✕/collapsed-pill — the
  scroll + collapse model replaces drag-to-size (mirrors the SummaryResizer
  removal).

Verified live against cli/cli#13510: sections collapse/expand, state persists
across reload, footer pinned, no console errors. typecheck + 70 tests + build green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 3, 2026
The HealthBanner renders null when healthy, so .app had only two children
(header + .main). With a fixed 3-track grid (52px auto 1fr), .main landed on
the 'auto' row and the 1fr row sat empty — the diff and rail only filled the
top of the screen, leaving a black gap, and 'Ready to approve' floated mid-page.

Switch .app to a flex column (header fixed 52px, optional banner, .main flex:1)
so .main always eats the remaining height regardless of whether the banner
renders. The diff now fills the screen and the footer pins to the bottom.

Verified live against cli/cli#13510: full-height diff, footer pinned bottom,
sections collapse/expand correctly, no console errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 4, 2026
Driven by live feedback after the first tab redesign:

- Rename 'Changes & Risks' -> 'Key Points' (not every PR has a risk, so
  '& Risks' over-promised).
- Calmer inline code: one shared treatment across Plain English / Key Points /
  Checklist / Summary / Before-After — warm amber (--ident #e3a857) in a
  hairline chip instead of a saturated-blue bordered chip on every identifier.
- Fix the Checklist Jira source-note contrast (was accent-blue text on an
  accent-blue tint): bright --fg text, key + link in --info.
- Layout: drop the full-width Summary band; SummaryCard now sits at the top of
  the left rail (Summary + Before/After -> TL;DR tabs -> files) and the diff
  starts at the very top, full height. The ~420px rail caps line length that
  used to run 150+ chars wide; the summary headline + before/after now render
  backticks as amber chips instead of literal backticks.
- Remove the now-dead SummaryResizer component and summaryHeight preference;
  the card is content-height in the rail (capped, scrolls internally).
- Focus mode: dropped — the new layout + existing rail resizer make it redundant.

Verified live against cli/cli#13510: all four tabs render, amber chips read
cleanly, no console errors. typecheck + 70 tests + build all green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 4, 2026
Left rail couldn't scroll (tall content unreachable) and there was no easy
way to hide parts to focus on the files + code.

- Single scroll rail: .rail-scroll (flex:1, overflow-y:auto) holds the three
  sections at natural height; ReviewFooter stays pinned below. Dropped the
  per-pane 50vh internal scrolls (no more nested scrollbars).
- Collapsible sections via a shared RailSectionHead (chevron + title, optional
  right slot): 📌 Summary, 💡 Insights (tabs), 🗂 Files (reviewed count in the
  right slot). Each collapses to a slim header; state persists per section
  (summaryCollapsed / tldrCollapsed / filesCollapsed) so 'collapse Summary +
  Insights to scan files + code' survives reload.
- Removed TLDRResizer + tldrHeight pref and the TL;DR ✕/collapsed-pill — the
  scroll + collapse model replaces drag-to-size (mirrors the SummaryResizer
  removal).

Verified live against cli/cli#13510: sections collapse/expand, state persists
across reload, footer pinned, no console errors. typecheck + 70 tests + build green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 4, 2026
The HealthBanner renders null when healthy, so .app had only two children
(header + .main). With a fixed 3-track grid (52px auto 1fr), .main landed on
the 'auto' row and the 1fr row sat empty — the diff and rail only filled the
top of the screen, leaving a black gap, and 'Ready to approve' floated mid-page.

Switch .app to a flex column (header fixed 52px, optional banner, .main flex:1)
so .main always eats the remaining height regardless of whether the banner
renders. The diff now fills the screen and the footer pins to the bottom.

Verified live against cli/cli#13510: full-height diff, footer pinned bottom,
sections collapse/expand correctly, no console errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 4, 2026
… layout (#8)

* docs: TL;DR panel tab redesign spec

Rename Brief -> Changes & Risks (card stack, 🎯), make Checklist
Jira-aware with a source note, remove Tweet. Defer PM view / Flow.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* ux: redesign TL;DR tabs — Changes & Risks, Jira-aware Checklist, drop Tweet

- Brief -> Changes & Risks: color-coded card stack (core/risk/context),
  file:line pinned as a chip; emoji 📌 -> 🎯 to stop clashing with the
  top SummaryCard.
- Checklist stays labelled Checklist but is now Jira-aware. New shared
  checklistSource() picks the grounding: full Jira (token present + ticket
  has a description) -> items derived from the ticket's acceptance criteria
  via buildChecklistAcPrompt; link-only / no Jira -> AI-generated. An in-pane
  source note (Jira chevron + key + link, or '✨ AI-generated') says which.
- Inject the ticket description only for this persona's system prompt, not
  via formatJiraContext (which deliberately keeps descriptions out).
- Remove the Tweet tab/persona (redundant with the top summary).
- Extract JiraIcon into a shared component (reused by JiraBadge + checklist).
- Tests for checklistSource's three states.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* ux: left-rail layout + readability pass on the TL;DR panel

Driven by live feedback after the first tab redesign:

- Rename 'Changes & Risks' -> 'Key Points' (not every PR has a risk, so
  '& Risks' over-promised).
- Calmer inline code: one shared treatment across Plain English / Key Points /
  Checklist / Summary / Before-After — warm amber (--ident #e3a857) in a
  hairline chip instead of a saturated-blue bordered chip on every identifier.
- Fix the Checklist Jira source-note contrast (was accent-blue text on an
  accent-blue tint): bright --fg text, key + link in --info.
- Layout: drop the full-width Summary band; SummaryCard now sits at the top of
  the left rail (Summary + Before/After -> TL;DR tabs -> files) and the diff
  starts at the very top, full height. The ~420px rail caps line length that
  used to run 150+ chars wide; the summary headline + before/after now render
  backticks as amber chips instead of literal backticks.
- Remove the now-dead SummaryResizer component and summaryHeight preference;
  the card is content-height in the rail (capped, scrolls internally).
- Focus mode: dropped — the new layout + existing rail resizer make it redundant.

Verified live against cli/cli#13510: all four tabs render, amber chips read
cleanly, no console errors. typecheck + 70 tests + build all green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* ux: scrollable left rail with collapsible Summary / Insights / Files

Left rail couldn't scroll (tall content unreachable) and there was no easy
way to hide parts to focus on the files + code.

- Single scroll rail: .rail-scroll (flex:1, overflow-y:auto) holds the three
  sections at natural height; ReviewFooter stays pinned below. Dropped the
  per-pane 50vh internal scrolls (no more nested scrollbars).
- Collapsible sections via a shared RailSectionHead (chevron + title, optional
  right slot): 📌 Summary, 💡 Insights (tabs), 🗂 Files (reviewed count in the
  right slot). Each collapses to a slim header; state persists per section
  (summaryCollapsed / tldrCollapsed / filesCollapsed) so 'collapse Summary +
  Insights to scan files + code' survives reload.
- Removed TLDRResizer + tldrHeight pref and the TL;DR ✕/collapsed-pill — the
  scroll + collapse model replaces drag-to-size (mirrors the SummaryResizer
  removal).

Verified live against cli/cli#13510: sections collapse/expand, state persists
across reload, footer pinned, no console errors. typecheck + 70 tests + build green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(layout): make the work area fill the full viewport height

The HealthBanner renders null when healthy, so .app had only two children
(header + .main). With a fixed 3-track grid (52px auto 1fr), .main landed on
the 'auto' row and the 1fr row sat empty — the diff and rail only filled the
top of the screen, leaving a black gap, and 'Ready to approve' floated mid-page.

Switch .app to a flex column (header fixed 52px, optional banner, .main flex:1)
so .main always eats the remaining height regardless of whether the banner
renders. The diff now fills the screen and the footer pins to the bottom.

Verified live against cli/cli#13510: full-height diff, footer pinned bottom,
sections collapse/expand correctly, no console errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(key-points): tag cards from the model; move effort pill to diff toolbar

Key Points cards were classified by a client-side keyword regex over the first
80 chars of each bullet, so a bullet led by a long identifier missed its signal
words and fell back to 'Context' — even when it was the core change (e.g. PR
#277 showed Context/Risk/Context with no Core card).

- TL;DR prompt now requires each bullet to start with CHANGE: / RISK: /
  CONTEXT:. parseBullets reads the tag (CHANGE→core, RISK→risk, CONTEXT→note)
  and strips it from the displayed text. classify() stays as a fallback for
  untagged/legacy output and now scans the whole bullet, not just 80 chars.
- Move the review-effort pill out of the Summary card into the diff toolbar,
  right-aligned on the same row as View/Theme (it describes the code, so it
  belongs on the code's toolbar).

Verified live against PR #277: cards now render Core change / ⚠ Risk / Context
correctly (the core change is the lead card again); effort pill sits top-right
in the toolbar. typecheck + 70 tests + build green; no app console errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(ui): let long code chips wrap so they don't overflow Before/After cards

The shared inline-code chip rule had white-space:nowrap, so a long token like
'GET /v1/products/{productId}/plans' couldn't wrap and bled past the right edge
of the narrow Before/After cards. Replace nowrap with overflow-wrap:anywhere so
long identifiers/paths break and stay inside the card.

Verified: a long chip in a 180px card now wraps (height ~3 lines) and no longer
overflows (measured chipRight 165 <= cardRight 180).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 4, 2026
…ighlights (#9)

1. Blame gutter: the blame string was sized to exactly blameWidth chars while
   the gutter reserved blameWidth chars AND the CSS added 6px right padding, so
   the trailing line number was pushed past the tinted element's right edge onto
   the bare decorations margin. Reserve blameWidth+2 chars and drop the right
   padding so the whole row — including the line number — stays inside the tint.
   (Measured: number now sits ~10px inside the tint, numberCovered=true.)
2. Round the intra-line (word-level) diff highlights (.char-insert/.char-delete)
   to 3px so partial-line changes read like GitHub's token highlights instead of
   hard rectangles. Whole-line backgrounds stay square.

Verified live against cli/cli#13510. typecheck + 70 tests + build green.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash added a commit to shacharPash/pr-review-assistant that referenced this pull request Jun 4, 2026
…losed PRs (#12)

The review footer submits an Approve/Comment/Request-changes review to GitHub,
but on a merged or closed PR those actions are invalid — yet it still showed the
green 'Ready to approve' CTA. Replace it, for merged/closed PRs, with a calm
non-actionable status note (purple for merged, red for closed) + a 'View on
GitHub' link. Open/Draft keep the full review footer.

Verified live on cli/cli#13510 (merged): footer shows 'This PR is merged —
review actions don't apply.' instead of the CTA. typecheck + build green, no
console errors.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants