Fix blame tint coverage + round intra-line diff highlights#9
Merged
Conversation
…ighlights 1. Blame gutter: the blame string was sized to exactly blameWidth chars while the gutter reserved blameWidth chars AND the CSS added 6px right padding, so the trailing line number was pushed past the tinted element's right edge onto the bare decorations margin. Reserve blameWidth+2 chars and drop the right padding so the whole row — including the line number — stays inside the tint. (Measured: number now sits ~10px inside the tint, numberCovered=true.) 2. Round the intra-line (word-level) diff highlights (.char-insert/.char-delete) to 3px so partial-line changes read like GitHub's token highlights instead of hard rectangles. Whole-line backgrounds stay square. Verified live against cli/cli#13510. typecheck + 70 tests + build green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shacharPash
added a commit
that referenced
this pull request
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small diff-view polish fixes from review feedback.
blameWidthchars, the gutter reserved exactlyblameWidthchars, and the gutter CSS added 6px of right padding — so the trailing line number got squeezed past the tinted element's right edge onto the bare decorations margin (looked like the color "didn't reach the numbers"). ReserveblameWidth + 2chars and drop the right padding. Measured live: the number now sits ~10px inside the tint (numberCovered: true).border-radius: 3pxto Monaco's.char-insert/.char-delete(the red/green spans on the part of a line that changed) so partial-line edits read like GitHub's token highlights instead of hard rectangles. Whole-line backgrounds stay square.Verification
typecheck+ 70 tests +buildgreencli/cli#13510: blame number covered (10px slack, measured),char-insert/deletecomputedborder-radius: 3px.🤖 Generated with Claude Code