Status-aware review footer (no 'Ready to approve' on merged/closed PRs)#12
Merged
Merged
Conversation
…losed PRs The review footer submits an Approve/Comment/Request-changes review to GitHub, but on a merged or closed PR those actions are invalid — yet it still showed the green 'Ready to approve' CTA. Replace it, for merged/closed PRs, with a calm non-actionable status note (purple for merged, red for closed) + a 'View on GitHub' link. Open/Draft keep the full review footer. Verified live on cli/cli#13510 (merged): footer shows 'This PR is merged — review actions don't apply.' instead of the CTA. typecheck + build green, no console errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the status badges (#11): the footer submits a real Approve/Comment/Request-changes review to GitHub, so showing 'Ready to approve' on a merged or closed PR was wrong (those actions are invalid).
Now, for merged/closed PRs, the footer shows a calm non-actionable note instead — '🟣 This PR is merged — review actions don't apply.' (purple) / '🔴 This PR is closed …' (red) — plus a View on GitHub link. Open/Draft PRs keep the full review footer.
Verification
cli/cli#13510(merged): footer renders the status note, not the CTA; no console errors.🤖 Generated with Claude Code