Issue #18673: Organize openrewrite staticanalysis composite recipes by groups as it is done on openrewrite website#18798
Closed
Brijeshthummar02 wants to merge 1 commit into
Closed
Conversation
|
kindly consider: already extracted CommonStaticAnalysis and this should be the only one in order not to over do it. ---
type: specs.openrewrite.org/v1beta/recipe
# workaround, as pom declaration not working...
name: org.checkstyle.AllAutoFixes
recipeList:
- org.checkstyle.CheckstyleAutoFix
- org.checkstyle.RefasterRules
- org.checkstyle.StaticAnalysis
---
type: specs.openrewrite.org/v1beta/recipe
name: org.checkstyle.CheckstyleAutoFix
description: Checkstyle standard fixes.
recipeList:
- org.checkstyle.autofix.CheckstyleAutoFix:
violationReportPath: target/cs_errors.xml
configurationPath: config/checkstyle-checks.xml
propertiesPath: config/openrewrite-recipes-checkstyle.properties
---
type: specs.openrewrite.org/v1beta/recipe
name: org.checkstyle.RefasterRules
description: Picnic Refaster rules.
recipeList:
- tech.picnic.errorprone.refasterrules.BigDecimalRulesRecipes
- tech.picnic.errorprone.refasterrules.CharSequenceRulesRecipes
- tech.picnic.errorprone.refasterrules.ClassRulesRecipes
- tech.picnic.errorprone.refasterrules.CollectionRulesRecipes
- tech.picnic.errorprone.refasterrules.ComparatorRulesRecipes
- tech.picnic.errorprone.refasterrules.FileRulesRecipes
- tech.picnic.errorprone.refasterrules.MapRulesRecipes
- tech.picnic.errorprone.refasterrules.MicrometerRulesRecipes
- tech.picnic.errorprone.refasterrules.MockitoRulesRecipes
# current maintainer don't "like" orElseThrow() as better form of get()
# - tech.picnic.errorprone.refasterrules.OptionalRulesRecipes
- tech.picnic.errorprone.refasterrules.PatternRulesRecipes
- tech.picnic.errorprone.refasterrules.PreconditionsRulesRecipes
- tech.picnic.errorprone.refasterrules.PrimitiveRulesRecipes
- tech.picnic.errorprone.refasterrules.StreamRulesRecipes
- tech.picnic.errorprone.refasterrules.TimeRulesRecipes
---
type: specs.openrewrite.org/v1beta/recipe
name: org.checkstyle.StaticAnalysis
description: OpenRewrite standard fixes.
recipeList:
- org.checkstyle.CommonStaticAnalysis
- org.openrewrite.java.RemoveUnusedImports
- org.openrewrite.java.ShortenFullyQualifiedTypeReferences
- org.openrewrite.java.SimplifySingleElementAnnotation
- org.openrewrite.java.format.EmptyNewlineAtEndOfFile
- org.openrewrite.java.format.NormalizeFormat
- org.openrewrite.java.format.NormalizeLineBreaks
- org.openrewrite.java.format.PadEmptyForLoopComponents
- org.openrewrite.java.format.RemoveTrailingWhitespace
- org.openrewrite.java.migrate.UpgradeToJava21
- org.openrewrite.java.migrate.lang.StringRulesRecipes
- org.openrewrite.java.migrate.util.MigrateInflaterDeflaterToClose
- org.openrewrite.java.migrate.util.ReplaceStreamCollectWithToList
- org.openrewrite.java.migrate.util.SequencedCollection
- org.openrewrite.java.recipes.JavaRecipeBestPractices
- org.openrewrite.java.recipes.RecipeTestingBestPractices
- org.openrewrite.maven.BestPractices
- org.openrewrite.staticanalysis.BufferedWriterCreationRecipes
- org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators
- org.openrewrite.staticanalysis.HideUtilityClassConstructor
- org.openrewrite.staticanalysis.JavaApiBestPractices
- org.openrewrite.staticanalysis.LowercasePackage
- org.openrewrite.staticanalysis.MissingOverrideAnnotation
- org.openrewrite.staticanalysis.OperatorWrap
- org.openrewrite.staticanalysis.RemoveUnusedLocalVariables
- org.openrewrite.staticanalysis.RemoveUnusedPrivateFields
- org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods
- org.openrewrite.staticanalysis.ReplaceThreadRunWithThreadStart
- org.openrewrite.staticanalysis.SimplifyTernaryRecipes
- org.openrewrite.staticanalysis.TypecastParenPad
- org.openrewrite.staticanalysis.URLEqualsHashCodeRecipes
- org.openrewrite.staticanalysis.UseLambdaForFunctionalInterface
---
type: specs.openrewrite.org/v1beta/recipe
name: org.checkstyle.CommonStaticAnalysis
recipeList:
- org.openrewrite.staticanalysis.AbstractClassPublicConstructor
- org.openrewrite.staticanalysis.AtomicPrimitiveEqualsUsesGet
- org.openrewrite.staticanalysis.BigDecimalDoubleConstructorRecipe
- org.openrewrite.staticanalysis.BigDecimalRoundingConstantsToEnums
- org.openrewrite.staticanalysis.BooleanChecksNotInverted
- org.openrewrite.staticanalysis.BufferedWriterCreationRecipes
- org.openrewrite.staticanalysis.CaseInsensitiveComparisonsDoNotChangeCase
- org.openrewrite.staticanalysis.CatchClauseOnlyRethrows
- org.openrewrite.staticanalysis.ChainStringBuilderAppendCalls
- org.openrewrite.staticanalysis.CollectionToArrayShouldHaveProperType
- org.openrewrite.staticanalysis.CovariantEquals
- org.openrewrite.staticanalysis.CustomImportOrder
- org.openrewrite.staticanalysis.DefaultComesLast
- org.openrewrite.staticanalysis.EmptyBlock
- org.openrewrite.staticanalysis.EqualsAvoidsNull
- org.openrewrite.staticanalysis.ExplicitInitialization
- org.openrewrite.staticanalysis.ExternalizableHasNoArgsConstructor
- org.openrewrite.staticanalysis.FinalizePrivateFields
- org.openrewrite.staticanalysis.FallThrough
- org.openrewrite.staticanalysis.FinalClass
- org.openrewrite.staticanalysis.FixStringFormatExpressions
- org.openrewrite.staticanalysis.ForLoopIncrementInUpdate
- org.openrewrite.staticanalysis.IndexOfChecksShouldUseAStartPosition
- org.openrewrite.staticanalysis.IndexOfReplaceableByContains
- org.openrewrite.staticanalysis.IndexOfShouldNotCompareGreaterThanZero
- org.openrewrite.staticanalysis.InlineVariable
- org.openrewrite.staticanalysis.IsEmptyCallOnCollections
- org.openrewrite.staticanalysis.LambdaBlockToExpression
- org.openrewrite.staticanalysis.MethodNameCasing
- org.openrewrite.staticanalysis.MinimumSwitchCases
- org.openrewrite.staticanalysis.ModifierOrder
- org.openrewrite.staticanalysis.MultipleVariableDeclarations
- org.openrewrite.staticanalysis.NeedBraces
- org.openrewrite.staticanalysis.NestedEnumsAreNotStatic
- org.openrewrite.staticanalysis.NewStringBuilderBufferWithCharArgument
- org.openrewrite.staticanalysis.NoDoubleBraceInitialization
- org.openrewrite.staticanalysis.NoEmptyCollectionWithRawType
- org.openrewrite.staticanalysis.NoEqualityInForCondition
- org.openrewrite.staticanalysis.NoFinalizer
- org.openrewrite.staticanalysis.NoPrimitiveWrappersForToStringOrCompareTo
- org.openrewrite.staticanalysis.NoRedundantJumpStatements
- org.openrewrite.staticanalysis.NoToStringOnStringType
- org.openrewrite.staticanalysis.NoValueOfOnStringType
- org.openrewrite.staticanalysis.ObjectFinalizeCallsSuper
- org.openrewrite.staticanalysis.PreferSystemGetPropertyOverGetenv
- org.openrewrite.staticanalysis.PrimitiveWrapperClassConstructorToValueOf
- org.openrewrite.staticanalysis.RedundantFileCreation
- org.openrewrite.staticanalysis.RemoveExtraSemicolons
- org.openrewrite.staticanalysis.RemoveRedundantNullCheckBeforeInstanceof
- org.openrewrite.staticanalysis.RemoveRedundantNullCheckBeforeLiteralEquals
- org.openrewrite.staticanalysis.RenameMethodsNamedHashcodeEqualOrToString
- org.openrewrite.staticanalysis.ReplaceClassIsInstanceWithInstanceof
- org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
- org.openrewrite.staticanalysis.ReplaceStringBuilderWithString
- org.openrewrite.staticanalysis.ReplaceStringConcatenationWithStringValueOf
- org.openrewrite.staticanalysis.SimplifyArraysAsList
- org.openrewrite.staticanalysis.SimplifyBooleanExpression
- org.openrewrite.staticanalysis.SimplifyBooleanReturn
- org.openrewrite.staticanalysis.StaticMethodNotFinal
- org.openrewrite.staticanalysis.StringLiteralEquality
- org.openrewrite.staticanalysis.UnnecessaryCloseInTryWithResources
- org.openrewrite.staticanalysis.UnnecessaryExplicitTypeArguments
- org.openrewrite.staticanalysis.UnnecessaryParentheses
- org.openrewrite.staticanalysis.UnnecessaryPrimitiveAnnotations
- org.openrewrite.staticanalysis.UnnecessaryReturnAsLastStatement
- org.openrewrite.staticanalysis.UpperCaseLiteralSuffixes
- org.openrewrite.staticanalysis.UseDiamondOperator
- org.openrewrite.staticanalysis.UseJavaStyleArrayDeclarations
- org.openrewrite.staticanalysis.UsePortableNewlines
- org.openrewrite.staticanalysis.WhileInsteadOfFor
- org.openrewrite.staticanalysis.WriteOctalValuesAsDecimal
- org.openrewrite.kotlin.cleanup.EqualsMethodUsage
- org.openrewrite.kotlin.cleanup.ImplicitParameterInLambda
- org.openrewrite.kotlin.cleanup.ReplaceCharToIntWithCode
- org.openrewrite.staticanalysis.CustomImportOrder |
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Member
|
@Brijeshthummar02, please follow issue target, no distractions on other updates |
romani
requested changes
Feb 11, 2026
romani
left a comment
Member
There was a problem hiding this comment.
please organoze compisite recipes on top
| # Static analysis composite recipes (include further recipes) | ||
| - org.openrewrite.staticanalysis.BufferedWriterCreationRecipes | ||
| - org.openrewrite.staticanalysis.EqualsAvoidsNull | ||
| - org.openrewrite.staticanalysis.CodeCleanup |
Member
There was a problem hiding this comment.
recipeList:
# composite recipes
- org.checkstyle.autofix.CheckstyleAutoFix:
violationReportPath: target/cs_errors.xml
configurationPath: config/checkstyle-checks.xml
propertiesPath: config/openrewrite-recipes-checkstyle.properties
- org.openrewrite.staticanalysis.CodeCleanup
# individual recipes
.....
551f1ae to
76bd8bd
Compare
Member
|
@Brijeshthummar02, please never rebase in web. |
6c87872 to
d8d27a0
Compare
Contributor
Author
My bad, i forgot to fetch the latest changes and due to it got a merge conflict i lost track of entire changes and issue. |
d8d27a0 to
59e8b6a
Compare
… recipes by groups as it is done on openrewrite website
59e8b6a to
c8532a7
Compare
Member
|
@Brijeshthummar02 , please read #18673 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #18673
Continue of #18676
Restructured the static analysis recipes in rewrite.yml to follow the same grouping used on the OpenRewrite documentation: