Skip to content

Pull #18756: Add CommonStaticAnalysis#18756

Closed
Pankraz76 wants to merge 1 commit into
checkstyle:masterfrom
Pankraz76:fin-CommonStaticAnalysis
Closed

Pull #18756: Add CommonStaticAnalysis#18756
Pankraz76 wants to merge 1 commit into
checkstyle:masterfrom
Pankraz76:fin-CommonStaticAnalysis

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Jan 25, 2026 •
edited
Loading

Copy link
Copy Markdown

@Pankraz76 Pankraz76 changed the title Pull #18610: Align rewrite readme batch #18589 #18700 Pull #18756: Align rewrite readme batch #18589 #18700 Jan 25, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 25, 2026
Pull checkstyle#18756: Align rewrite readme batch checkstyle#18589 ch…
25d0614 
…eckstyle#18700
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch 2 times, most recently from 25d0614 to 17de064 Compare January 25, 2026 10:41
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 25, 2026
Pull checkstyle#18756: Align rewrite readme batch checkstyle#18589 ch…
17de064 
…eckstyle#18700
@Pankraz76 Pankraz76 changed the title Pull #18756: Align rewrite readme batch #18589 #18700 Pull #18700: Add org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676 #18700 Jan 25, 2026
@Pankraz76 Pankraz76 changed the title Pull #18700: Add org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676 #18700 Pull #18756: Add org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676 #18700 Jan 25, 2026
@Pankraz76 Pankraz76 changed the title Pull #18756: Add org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676 #18700 Pull #18756: Add CommonStaticAnalysis #18673 #18676 #18700 Jan 25, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 25, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis checkstyle#18673 ch…
d23e991 
…eckstyle#18676 checkstyle#18700
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 17de064 to d23e991 Compare January 25, 2026 10:49
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 25, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis checkstyle#18673 ch…
eea0d01 
…eckstyle#18676 checkstyle#18700
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from d23e991 to eea0d01 Compare January 25, 2026 11:57
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 25, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis checkstyle#18673 ch…
99501c4 
…eckstyle#18676 checkstyle#18700
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from eea0d01 to 99501c4 Compare January 25, 2026 12:04
@Pankraz76 Pankraz76 marked this pull request as ready for review January 25, 2026 12:26
@Pankraz76 Pankraz76 mentioned this pull request Jan 25, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 25, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis checkstyle#18673 ch…
f9fc117 
…eckstyle#18676 checkstyle#18700
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 99501c4 to f9fc117 Compare January 25, 2026 12:30
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 25, 2026
@Pankraz76
Pull checkstyle#18756: Add CommonStaticAnalysis checkstyle#18673 ch…
54e77de 
…eckstyle#18676 checkstyle#18700
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from f9fc117 to 54e77de Compare January 25, 2026 13:59
@romani

romani commented Jan 25, 2026

Copy link
Copy Markdown
Member

as it is composite list it should stay composite in out config

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.staticanalysis.CommonStaticAnalysis
displayName: Common static analysis issues
description: |
  Resolve common static analysis issues (also known as SAST issues).
recipeList:

@Pankraz76 Pankraz76 mentioned this pull request Jan 29, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis checkstyle#18673 ch…
8e1a521 
…eckstyle#18676 checkstyle#18700
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 54e77de to 8e1a521 Compare January 30, 2026 15:06
romani
romani requested changes Jan 30, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last

Comment thread .circleci/config.yml Outdated
@Pankraz76 Pankraz76 changed the title Pull #18756: Add CommonStaticAnalysis #18673 #18676 #18700 Pull #18756: Add CommonStaticAnalysis #18673 #18676 #18700 #18794 Jan 31, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis checkstyle#18673 ch…
a644d2d 
…eckstyle#18676 checkstyle#18700 checkstyle#18794
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 8e1a521 to a644d2d Compare January 31, 2026 12:56
@Pankraz76 Pankraz76 changed the title Pull #18756: Add CommonStaticAnalysis #18673 #18676 #18700 #18794 Pull #18756: Add CommonStaticAnalysis #18673 #18676 #18700 #18794 #18798 Jan 31, 2026
@Pankraz76 Pankraz76 mentioned this pull request Jan 31, 2026
Closed
@Pankraz76

Pankraz76 commented Feb 4, 2026

Copy link
Copy Markdown
Author

Merged fix-AutoFixesPart1 to fin-CommonStaticAnalysis

@Pankraz76 Pankraz76 requested a review from romani February 4, 2026 19:43
@Pankraz76

Pankraz76 commented Feb 4, 2026

Copy link
Copy Markdown
Author

after 21 this one 100% focus:

@romani romani changed the title Pull #18756: Add CommonStaticAnalysis #18673 #18676 #18700 #18794 #18798 Pull #18756: Add CommonStaticAnalysis Feb 4, 2026
@romani romani changed the title Pull #18756: Add CommonStaticAnalysis Pull #18756: Add CommonStaticAnalysis Feb 4, 2026
romani
romani requested changes Feb 4, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Comment thread config/rewrite.yml Outdated
@Pankraz76 Pankraz76 closed this Feb 4, 2026
@Pankraz76 Pankraz76 reopened this Feb 6, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 6, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis
82acb6f
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 7f1e42c to 82acb6f Compare February 6, 2026 13:02
@Pankraz76 Pankraz76 requested a review from romani February 6, 2026 13:04
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 6, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis
ddb2e27
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 82acb6f to ddb2e27 Compare February 6, 2026 13:30
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 6, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis
3443e86
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from ddb2e27 to 3443e86 Compare February 6, 2026 13:42
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 6, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis
af334f9
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 3443e86 to af334f9 Compare February 6, 2026 13:51
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 6, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis
176e37a
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from af334f9 to 176e37a Compare February 6, 2026 14:04
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 6, 2026
Pull checkstyle#18756: Add CommonStaticAnalysis
ff236f6
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from 176e37a to ff236f6 Compare February 6, 2026 14:05
Pankraz76
Pankraz76 commented Feb 6, 2026
View reviewed changes
Comment thread config/rewrite.yml Outdated
- tech.picnic.errorprone.refasterrules.BigDecimalRulesRecipes
- tech.picnic.errorprone.refasterrules.CharSequenceRulesRecipes
- tech.picnic.errorprone.refasterrules.ClassRulesRecipes
# - tech.picnic.errorprone.refasterrules.ClassRulesRecipes

@Pankraz76 Pankraz76 Feb 6, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one causing the first issue again not that you go crazy and say its unrelated again @romani block me for no reason

Pankraz76
Pankraz76 commented Feb 6, 2026
View reviewed changes
Comment thread src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java
// or
// previous static but current is non-static (under)
previous
||

@Pankraz76 Pankraz76 Feb 6, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here its moving this file from recipe its not unrelated as well.

@Pankraz76

Pankraz76 commented Feb 6, 2026

Copy link
Copy Markdown
Author 
     .that(violations)
         .hasSize(1);

  •    final Violation violation = violations.getFirst();

  •    final String retrievedMessage = violations.getFirst().getKey();

  •    final Violation violation = violations.first();

  •    final String retrievedMessage = violations.first().getKey();
   assertWithMessage("violation key '%s' is not valid", retrievedMessage)
       .that(retrievedMessage)
       .isEqualTo("unable.open.cause");

EOF

@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis branch from ff236f6 to a102fa8 Compare February 6, 2026 15:08
Pankraz76
Pankraz76 commented Feb 6, 2026
View reviewed changes
Comment thread config/rewrite.yml
- tech.picnic.errorprone.refasterrules.CharSequenceRulesRecipes
- tech.picnic.errorprone.refasterrules.ClassRulesRecipes
- tech.picnic.errorprone.refasterrules.CollectionRulesRecipes
# - tech.picnic.errorprone.refasterrules.CollectionRulesRecipes

@Pankraz76 Pankraz76 Feb 6, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabler:

@Pankraz76 Pankraz76 mentioned this pull request Feb 6, 2026
Merged
@Pankraz76

Pankraz76 commented Feb 7, 2026

Copy link
Copy Markdown
Author

wait for enabler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani Awaiting requested review from romani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @romani