Pull #18700: Add org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676#18700
Closed
Pankraz76 wants to merge 1 commit into
Closed
Pull #18700: Add org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676#18700Pankraz76 wants to merge 1 commit into
org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676#18700Pankraz76 wants to merge 1 commit into
Conversation
f84bb66 to
46c106f
Compare
org.checkstyle.CommonStaticAnalysis #18673 #18676org.checkstyle.CommonStaticAnalysis #18673 #18676
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 20, 2026
46c106f to
80352be
Compare
org.checkstyle.CommonStaticAnalysis #18673 #18676org.checkstyle.openrewrite.CommonStaticAnalysis #18673 #18676
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
80352be to
cab6467
Compare
Pankraz76
commented
Jan 24, 2026
| - org.checkstyle.openrewrite.CodeCleanup | ||
| - org.checkstyle.openrewrite.CommonStaticAnalysis | ||
| - org.checkstyle.openrewrite.Refasterrules | ||
| - org.checkstyle.autofix.CheckstyleAutoFix: |
Author
There was a problem hiding this comment.
Suggested change
| - org.checkstyle.autofix.CheckstyleAutoFix: | |
| - org.checkstyle.openrewrite.autofix.CheckstyleAutoFix: |
this should be fixed as well, adding the sub domain and context.
looking just at the current de facto its not possible to tell its a rewrite stuff!!!
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
Pankraz76
commented
Jan 24, 2026
| - org.openrewrite.staticanalysis.URLEqualsHashCodeRecipes | ||
| - org.openrewrite.staticanalysis.UnnecessaryCloseInTryWithResources | ||
| - org.openrewrite.staticanalysis.UnnecessaryExplicitTypeArguments | ||
| - org.openrewrite.staticanalysis.UnnecessaryParentheses |
Author
There was a problem hiding this comment.
extract DRY as this comes from CodeCleanup as well.
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
5f97a23 to
af5eb4f
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
af5eb4f to
c2665eb
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
c2665eb to
ca0857e
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
ca0857e to
d929f31
Compare
Pankraz76
commented
Jan 24, 2026
| check.process(firstFile, new FileText(firstFile, Collections.emptyList())); | ||
|
|
||
| assertWithMessage("Invalid message") | ||
| .that(firstFileMessages.first().getViolation()) |
Author
There was a problem hiding this comment.
this is java 21 migration and comes form master....
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
d929f31 to
8befaa2
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
8befaa2 to
ae18e1b
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
ae18e1b to
751bac8
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 24, 2026
Member
|
bunch of unrelated changes to openrewtire. such style of contributions is not good, no chance to be merged. |
4 tasks
Author
|
lets just make recipes yes |
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 25, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 25, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 25, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 25, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 25, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 25, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 25, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 30, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 31, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 1, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull #18700: Add
org.checkstyle.openrewrite.CommonStaticAnalysis#18673 #18676kindly consider: @Brijeshthummar02 @romani