Changesets v3 tasks #1473

bluwy · 2024-10-03T15:11:20Z

bluwy
Oct 3, 2024
Maintainer

Update: Closed in favour of #1945. Unresolved tasks that are not covered in that issue will be pushed to v4

Note: This is separate from #665. In this discussion, I've discussed with @Andarist with some smaller scoped tasks and breaking changes to get v3 out in the near term. However, those listed in the issue may still be tackled on v4.

For quick chats and questions, or general interest in contributing, you can also hop in this Discord thread
(from the e18e server)

Work is being done in the next branch which is in prerelease mode

Goals

Proper node version support
Revisit deprecated or discouraged APIs
Revisit some behaviour quirkiness

Tasks

Improve package managers support (related Rework publishing to work with all popular package managers #674, Write tests for publishing #107)

Package manager	CI tests	Custom registry support	Workspaces suppport	Publish command works
npm 7
npm >7
yarn 1
yarn berry
pnpm

Prefer documenting fixed versioning before linked packages (which is harder to grasp)
Make onlyUpdatePeerDependentsWhenOutOfRange true by default (requires documentation for its implication)
Allow customizing peer deps bump strategy (Add a new bump strategy for peers bump #1132)
Rework dependency ranges update (Rework dependency ranges updates #975)
Drop support for changeset v1 (has different .changeset layout) (Remove changeset v1 support #1494)
- Check implications around https://github.com/changesets/bot (note: unaffected)
Set "engines" field in package.json (Set engines field to node 18 and above #1479)
Test multiple node versions in CI (Run CI on node 18, 20, and 22 #1480)
Upgrade dependencies to latest
- Check feat: serializable return values Thinkmill/manypkg#220 to unblock upgrade
Investigate existing dependencies usage (if we still need them or not, or switch to something else)
- fs-extra (Remove fs-extra #1476)
- p-filter (Remove changeset v1 support #1494)
- resolve-from (Switch all packages to being ESM-only #1482)
- prettier (make optional?)
- external-editor (there doesn't seem to be a similar library that allows editing temporary files inline of the CLI)
New website! (nice to have)

Notes:

Feel free to mention any breaking changes that are small in scope, or if you'd like to contribute to

Prefer to keep existing monorepo packages separation for now (don't combine or remove them)

Side tasks

It'd be nice to encourage a small community around contributing to changesets. It's being depended by many large projects today and I think there's an opportunity to encourage contributions back for things downstream likes to see.

Andarist · 2024-10-03T15:16:58Z

Andarist
Oct 3, 2024
Maintainer

Thanks for putting this together!

Discourage linked packages (hard to understand and get right, fixed versioning may be better)

It's not I'd like this to be discouraged per se - it should be enough to mention them later. Fixed packages are easier to grasp so I think they should be mentioned by the docs first etc.

Some other things I thought about:

we should revive Add a new bump strategy for peers bump #1132 one way or another, it would be great to have this behavior customizable
and we should also revive Rework dependency ranges updates #975 , from what I recall this "only" needs new tests 😅

2 replies

Andarist Oct 3, 2024
Maintainer

We should also remember about dropping support for Changesets v1 that used a different .changeset layout. We should think about implications of that for https://github.com/changesets/bot

bluwy Oct 3, 2024
Maintainer Author

Updated in the list 👍 Seems doable for the next major!

pralkarz · 2024-10-05T10:02:43Z

pralkarz
Oct 5, 2024

Logging per @Andarist's request in #1476 (comment).

Currently, it seems like the remote isn't consulted when creating a changeset, which causes an error when the "baseBranch" from the config doesn't exist locally:

$ packages/cli/bin.js
🦋  error Error: Failed to find where HEAD diverged from next. Does next exist?
🦋  error     at getDivergedCommit (/home/pralky/dev/changesets/packages/git/src/index.ts:51:11)
🦋  error     at getChangedFilesSince (/home/pralky/dev/changesets/packages/git/src/index.ts:196:22)
🦋  error     at getChangedPackagesSinceRef (/home/pralky/dev/changesets/packages/git/src/index.ts:258:24)
🦋  error     at getVersionableChangedPackages (/home/pralky/dev/changesets/packages/cli/src/utils/versionablePackages.ts:15:27)
🦋  error     at add (/home/pralky/dev/changesets/packages/cli/src/commands/add/index.ts:47:7)
🦋  error     at run (/home/pralky/dev/changesets/packages/cli/src/run.ts:72:5)

To reproduce from a blank slate:

Clone the repo and branch off off main (a different branch than "baseBranch".
Make some commits.
Run git pull upstream next (pull from the "baseBranch" from the remote; I personally use git config pull.rebase false, might be an issue when rebasing too).
Run yarn changeset -> error happens.
Run git pull upstream, then yarn changeset again -> error still happens. I haven't checked with git fetch upstream, but I assume it'd also break then.
Run git checkout next to force the refs to "register" locally, then back to your dev branch. yarn changeset works now as the next branch exists locally.

2 replies

bluwy Oct 5, 2024
Maintainer Author

It seems to happen if baseBranch is set to any branch name that doesn't exist locally. Maybe we should log a warning in this case and fallback to the default branch. IIRC the check is used for 2 cases:

Figure out the recommended packages that has changed when adding changesets (not very crucial if incorrect)
The getChangesets() function. (Kinda important to get the base branch right?)

So we could make no1 a warning, but keep no2 an error still 🤔

pralkarz Oct 5, 2024

In case we stick to resolving these two cases locally, I think throwing an error makes sense as the baseBranch can differ significantly from the default branch (especially for prerelease branches like next), so it could lead to many incorrect resolutions when falling back. I'd change "Does exists?" to something more actionable like "Make sure exists locally." or similar though so it's more straightforward to fix.

In case we decide to consult the remote(s), falling back to the default branch in the very rare case we cannot resolve the divergence would make more sense in my opinion.

~~I'm saying "we" because it's easier to write that way, but naturally the decision is up to you as the maintainers! 😄~~

carbonrobot · 2024-11-12T21:50:36Z

carbonrobot
Nov 12, 2024

Hey everyone 👋 I'm the Head of Open Source at Nearform (formerly Formidable) and we have many widely used open source projects that use Changesets. We would be more than happy to contribute our time to help with the next steps.

0 replies

bluwy · 2026-05-04T01:54:28Z

bluwy
May 4, 2026
Maintainer Author

Closing in favour of #1945. If anyone would like to help out, we have setup a discord server to quickly discuss things: https://discord.gg/5HvGtvR35W

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changesets v3 tasks #1473

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 4 comments 4 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Changesets v3 tasks #1473

Uh oh!

Uh oh!

bluwy Oct 3, 2024 Maintainer

Update: Closed in favour of #1945. Unresolved tasks that are not covered in that issue will be pushed to v4

Goals

Tasks

Side tasks

Replies: 4 comments · 4 replies

Uh oh!

Andarist Oct 3, 2024 Maintainer

Uh oh!

Andarist Oct 3, 2024 Maintainer

Uh oh!

bluwy Oct 3, 2024 Maintainer Author

Uh oh!

pralkarz Oct 5, 2024

Uh oh!

bluwy Oct 5, 2024 Maintainer Author

Uh oh!

pralkarz Oct 5, 2024

Uh oh!

carbonrobot Nov 12, 2024

Uh oh!

bluwy May 4, 2026 Maintainer Author

bluwy
Oct 3, 2024
Maintainer

Replies: 4 comments 4 replies

Andarist
Oct 3, 2024
Maintainer

Andarist Oct 3, 2024
Maintainer

bluwy Oct 3, 2024
Maintainer Author

pralkarz
Oct 5, 2024

bluwy Oct 5, 2024
Maintainer Author

carbonrobot
Nov 12, 2024

bluwy
May 4, 2026
Maintainer Author