Skip to content

Rework dependency ranges updates#975

Draft
Andarist wants to merge 2 commits intomainfrom
rework-dependency-ranges-updates
Draft

Rework dependency ranges updates#975
Andarist wants to merge 2 commits intomainfrom
rework-dependency-ranges-updates

Conversation

@Andarist
Copy link
Copy Markdown
Member

@Andarist Andarist commented Oct 6, 2022

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 6, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3ffdbe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Oct 6, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ffdbe0:

Sandbox Source
Vanilla Configuration

Andarist
Andarist commented Nov 1, 2022
View reviewed changes
Comment thread packages/apply-release-plan/src/utils.ts
Comment on lines +62 to +63
if (workspaceRange === "*" || workspaceRange?.includes("/")) {
return {
Copy link
Copy Markdown
Member Author

@Andarist Andarist Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: recheck if this shouldn't do a different thing with onlyUpdatePeerDependentsWhenOutOfRange: false

@Andarist
Merge branch 'main' into rework-dependency-ranges-updates
3ffdbe0 
# Conflicts:
#	packages/cli/src/commands/version/version.test.ts
@desfero
Copy link
Copy Markdown

desfero commented Feb 8, 2023

@Andarist great work, are there any blockers to push this one forward?
It Is causing us quite a pain with changeset in our monorepo setup as each update forces the major bump of the whole monorepo and we need to manually update generated package.jsons and CHANGELOG.mds.

@Andarist
Copy link
Copy Markdown
Member Author

Andarist commented Feb 8, 2023

@Andarist great work, are there any blockers to push this one forward?

Yes, the main blockers are:

  • my kids and family (aka the life and the available time :P)
  • lack of tests for the fixed cases

@Andarist Andarist mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Andarist @desfero