Skip to content

Remove changeset v1 support#1494

Merged
Andarist merged 2 commits intonextfrom
remove-read-legacy
Oct 31, 2024
Merged

Remove changeset v1 support#1494
Andarist merged 2 commits intonextfrom
remove-read-legacy

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Oct 10, 2024

This removes support for changeset in v1 format in the .changeset directory.

The previous warning mentions that it'll error instead of completely not supporting it (like in this PR), I don't know if we need to keep that behaviour though. It already feels like a long time ago.

At #1473, there's a mention about this change that could affect https://github.com/changesets/bot, however I can't tell how this affects that repo when reading the source.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 05af694

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@changesets/read Minor
@changesets/cli Patch
@changesets/get-release-plan Patch
@changesets/release-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@e0e1748). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1494   +/-   ##
=======================================
  Coverage        ?   80.82%           
=======================================
  Files           ?       53           
  Lines           ?     2216           
  Branches        ?      656           
=======================================
  Hits            ?     1791           
  Misses          ?      421           
  Partials        ?        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andarist
Copy link
Copy Markdown
Member

At #1473, there's a mention about this change that could affect https://github.com/changesets/bot, however I can't tell how this affects that repo when reading the source.

I thought it could affect it in a sense that it would no longer be able to read those old changeset files. This is an integration and the user can't chose to use a bot compatible with old changesets as that bot is updated out of their control.

Now, when looking through its code... I'm not sure if it handles that at all today:
https://github.com/changesets/bot/blob/a443d065be109aeb890cb97c14e5b34e3c4f4a88/get-changed-packages.ts#L96-L112

It might be able to read them (nested .md files should still be read by this logic) but the retrieved ID might be incorrect - I'm not sure what would happen then but there is a risk that it wouldn't quite work correctly.

But either way, that bot doesn't use @changesets/read - so this change here should be completely OK from its PoV.

@Andarist Andarist merged commit 6d1f384 into next Oct 31, 2024
@Andarist Andarist deleted the remove-read-legacy branch October 31, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants