🦋 Changeset detected

Latest commit: 60335f0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Looks like we also need to be a good citizen now and not use plain require, but createRequire or import instead 😄 Which is probably a good thing anyways. Interestingly this seems to imply that the pure ESM output we had in v2 never quite worked in node, only in bundlers that could handle bundling require().

Interestingly this seems to imply that the pure ESM output we had in v2 never quite worked in node

That's fine - node wasn't receiving any ESM files from us in v2 beyond short reexporting .mjs wrappers. They were just proxying to CJS files.

Codecov Report

Attention: Patch coverage is 89.83051% with 24 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (e4da05f) to head (60335f0).
Report is 1 commits behind head on next.

@@            Coverage Diff             @@
##             next    #1482      +/-   ##
==========================================
- Coverage   80.75%   71.65%   -9.10%     
==========================================
  Files          52       65      +13     
  Lines        2234     5007    +2773     
  Branches      665      871     +206     
==========================================
+ Hits         1804     3588    +1784     
- Misses        425     1414     +989     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmatown @bluwy this is ready for a proper review :)

@remorses is there any specific reason why you have downvoted this?

Looks great to me! I didn't expect Jest to be swapped out with Vitest here, but I welcome it 😄

I almost had it working with Jest but it tried to execute ESM node_modules through script.runInContext (or similar) and that just didn't work. I probably could make it transform node_modules but I gave up and just switched to Vitest

Should we add the major changesets too?

Yeah. Thanks for the reminder