Skip to content

Generate applyconfigurations and Apply functions#5383

Closed
inteon wants to merge 2 commits intocert-manager:masterfrom
inteon:applyconfigurations
Closed

Generate applyconfigurations and Apply functions#5383
inteon wants to merge 2 commits intocert-manager:masterfrom
inteon:applyconfigurations

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Aug 11, 2022 •
edited
Loading

Continuation of #5083.
Does not generate ExtractXXX functions because of additional openapi complexity and code.

fixes #5783

Release Note

Extended cert-manager api client functions with applyconfiguration structures

@inteon inteon requested a review from wallrj August 11, 2022 18:50
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/api Indicates a PR directly modifies the 'pkg/apis' directory labels Aug 11, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@inteon inteon force-pushed the applyconfigurations branch 3 times, most recently from 9258623 to 255419b Compare August 11, 2022 20:02
@JoshVanL
Copy link
Copy Markdown
Contributor

JoshVanL commented Aug 12, 2022

@inteon what is the benefit of these apply configurations over how we do applies currently?

This PR approaches doubling the number of lines of code in cert-manager/cert-manger.. Apprehensive to do so for purely cosmetic benefit.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2022
@inteon inteon marked this pull request as draft September 26, 2022 12:19
@jetstack-bot jetstack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2022
@EraYaN EraYaN mentioned this pull request Feb 8, 2023
Closed
@inteon inteon mentioned this pull request Feb 14, 2023
Closed
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Feb 14, 2023

TODO: validate the usefulness of this PR by trying to implement #5077 based on it.

@inteon inteon added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 14, 2023
@EraYaN EraYaN mentioned this pull request Feb 15, 2023
Closed
@inteon inteon force-pushed the applyconfigurations branch from 255419b to 7aa2957 Compare March 10, 2023 13:09
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2023
inteon added 2 commits March 10, 2023 14:16
@inteon
added applyconfigurations generation scripts
d70dff6 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
run 'make update-codegen'
30b5ce2 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the applyconfigurations branch from 7aa2957 to 30b5ce2 Compare March 10, 2023 13:17
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Apr 28, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
wallrj
wallrj requested changes Jun 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase.

I still think this would be useful. Especially as part of a future client-cert-manager module.

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Aug 25, 2023

@inteon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-e2e-v1-25 255419b link true /test pull-cert-manager-master-e2e-v1-25
pull-cert-manager-master-e2e-v1-24-upgrade 255419b link true /test pull-cert-manager-master-e2e-v1-24-upgrade
pull-cert-manager-master-e2e-v1-25-upgrade 255419b link true /test pull-cert-manager-master-e2e-v1-25-upgrade
pull-cert-manager-master-e2e-v1-26-upgrade 255419b link true /test pull-cert-manager-master-e2e-v1-26-upgrade
pull-cert-manager-master-e2e-v1-28-upgrade 30b5ce2 link true /test pull-cert-manager-master-e2e-v1-28-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wallrj
Copy link
Copy Markdown
Member

wallrj commented Nov 2, 2023

xref

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 31, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 1, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
/remove-lifecycle stale

@jetstack-bot jetstack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 1, 2024
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 31, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 31, 2024

@jetstack-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj requested changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add k8s.io/client-go/applyconfigurations style *ApplyConfigurations for the included CRDs

4 participants

@inteon @jetstack-bot @JoshVanL @wallrj