chore: generate applyconfigurations for custom resources#217
Merged
jetstack-bot merged 1 commit intocert-manager:mainfrom Nov 10, 2023
Merged
chore: generate applyconfigurations for custom resources#217jetstack-bot merged 1 commit intocert-manager:mainfrom
jetstack-bot merged 1 commit intocert-manager:mainfrom
Conversation
Member
|
/hold let's not merge this before the v0.7.0 release |
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Member
Author
|
The 0.7.0 release is history. /unhold |
Member
Author
|
/retest |
SgtCoDFish
approved these changes
Nov 10, 2023
Member
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
This doesn't seem to runtime impact currently - making it very easy to approve. Thanks for looking into this, I'm interested in following it!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test pull-trust-manager-verify |
This was referenced Nov 18, 2023
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the migration to SSA in this project made the code harder to read/understand. 😉 While the support for SSA in the controller-runtime client is limited at present, ref. kubernetes-sigs/controller-runtime#347, I am convinced that we can do better.
Generating applyconfigurations with controller-gen is in the making, ref. kubernetes-sigs/controller-tools#818 and kubernetes-sigs/controller-tools#536, but it's a complex task that still needs some work.
In the meantime, I suggest generating applyconfigurations using the upstream generator that we can use in our controllers. I also suggest exporting the generated applyconfiguration types, even if I think client types should be available without depending on the operator module - creating a potential dependency-hell. This has been a long-standing issue in cert-manager that I hope can get some progress soon.
/cc @inteon @SgtCoDFish