Skip to content

WIP: Generate applyconfigurations and Apply functions #5083

Closed
wallrj wants to merge 3 commits intocert-manager:masterfrom
wallrj:applyconfiguration-gen
Closed

WIP: Generate applyconfigurations and Apply functions #5083
wallrj wants to merge 3 commits intocert-manager:masterfrom
wallrj:applyconfiguration-gen

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Apr 30, 2022 

NONE

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 30, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Apr 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/testing Issues relating to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2022
@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented Apr 30, 2022

/retest
/test pull-cert-manager-e2e-v1-19

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented May 3, 2022

Thanks for working on this, I think we definitely want to do this.

Curious if this really solves the conflicts- would like to run the tests a couple more times as these errors only appear sometimes

/retest

@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented May 3, 2022

/test pull-cert-manager-e2e-v1-23

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented May 3, 2022

Seems like it still has the optimistic lock errors https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/pr-logs/pull/cert-manager_cert-manager/5083/pull-cert-manager-e2e-v1-23/1521417108288704512

wallrj added 3 commits May 3, 2022 14:52
@wallrj
Generate applyconfigurations and Apply functions
ad4a6c6 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
./hack/update-all.sh
5c6b9f1 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Update tests
a9f15ff 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj force-pushed the applyconfiguration-gen branch from f6ba4cf to a9f15ff Compare May 3, 2022 14:23
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 21, 2022

@wallrj: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inteon inteon self-assigned this Aug 11, 2022
@inteon inteon mentioned this pull request Aug 11, 2022
Closed
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Dec 19, 2022

@wallrj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-deps a9f15ff link true /test pull-cert-manager-deps
pull-cert-manager-make-e2e-v1-23 a9f15ff link true /test pull-cert-manager-make-e2e-v1-23
pull-cert-manager-bazel a9f15ff link true /test pull-cert-manager-bazel
pull-cert-manager-master-chart a9f15ff link true /test pull-cert-manager-master-chart
pull-cert-manager-master-make-test a9f15ff link true /test pull-cert-manager-master-make-test
pull-cert-manager-master-e2e-v1-24 a9f15ff link true /test pull-cert-manager-master-e2e-v1-24
pull-cert-manager-master-e2e-v1-25 a9f15ff link true /test pull-cert-manager-master-e2e-v1-25
pull-cert-manager-master-e2e-v1-24-upgrade a9f15ff link true /test pull-cert-manager-master-e2e-v1-24-upgrade
pull-cert-manager-master-e2e-v1-25-upgrade a9f15ff link true /test pull-cert-manager-master-e2e-v1-25-upgrade
pull-cert-manager-master-e2e-v1-26-upgrade a9f15ff link true /test pull-cert-manager-master-e2e-v1-26-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EraYaN EraYaN mentioned this pull request Feb 8, 2023
Closed
@inteon
Copy link
Copy Markdown
Member

inteon commented Feb 14, 2023

I'll close this in favor of #5383.

@inteon inteon closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@inteon inteon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wallrj @jetstack-bot @irbekrm @inteon