squid: mgr/vol: don't delete user-created pool in "volume create" command#63068
Open
rishabh-d-dave wants to merge 7 commits intoceph:squidfrom
Open
squid: mgr/vol: don't delete user-created pool in "volume create" command#63068rishabh-d-dave wants to merge 7 commits intoceph:squidfrom
rishabh-d-dave wants to merge 7 commits intoceph:squidfrom
Conversation
Fixes: https://tracker.ceph.com/issues/69878 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit e794a19)
Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 058769c)
Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 3ae1930)
Command "ceph fs volume create" accepts 2 new options to allow users to pass data and metadata pool name. Update docs to include mention of both the options. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 3044bf7)
in args. Add a release note that "ceph fs volume create" command allows users to pass pool names to "ceph fs volume create" command. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit a74dbbe)
If one of the pool names passed to "ceph fs volume create" command (through --data-pool and --meta-pool name) is absent, don't delete the pool that is present and passed to this command during the cleanup code of this command. IOW, "volume create" command should continue deleting pool created by it but not delete pool created by the user. Fixes: https://tracker.ceph.com/issues/70945 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 4299f66)
"volume create" command. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit ad1716f)
Contributor
Author
|
Depends on #62461 |
Member
|
This PR is under test in https://tracker.ceph.com/issues/72654. |
Member
|
This PR is under test in https://tracker.ceph.com/issues/74996. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/71150
backport of #62843
parent tracker: https://tracker.ceph.com/issues/70945
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh