squid: mgr/vol: allow passing pool names to "fs volume create" cmd#62461
Closed
rishabh-d-dave wants to merge 5 commits intoceph:squidfrom
Closed
squid: mgr/vol: allow passing pool names to "fs volume create" cmd#62461rishabh-d-dave wants to merge 5 commits intoceph:squidfrom
rishabh-d-dave wants to merge 5 commits intoceph:squidfrom
Conversation
8dbe9d0 to
6c2f32d
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Contributor
|
@rishabh-d-dave please fix the conflict |
Fixes: https://tracker.ceph.com/issues/69878 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit e794a19)
Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 058769c)
6c2f32d to
bab569a
Compare
Contributor
Author
Done. |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 3ae1930)
Command "ceph fs volume create" accepts 2 new options to allow users to pass data and metadata pool name. Update docs to include mention of both the options. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 3044bf7)
in args. Add a release note that "ceph fs volume create" command allows users to pass pool names to "ceph fs volume create" command. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit a74dbbe)
bab569a to
84f1a18
Compare
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/71055. |
1 similar comment
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/71055. |
fa9d585 to
84f1a18
Compare
Contributor
Author
|
Hey @kotreshhr I had added a couple more commits to this PR branch few minutes ago by mistake. I've removed them, the branch is same as before now. |
Member
|
Closing in favour of #63068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/70606
backport of #61732
parent tracker: https://tracker.ceph.com/issues/69878