Project

General

Profile

Actions

Feature #69878

open

mgr/vol: allow passing pool names to "fs volume create" cmd

Added by Rishabh Dave about 1 year ago. Updated 5 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Category:
Administration/Usability
Target version:
% Done:

0%

Source:
Development
Backport:
reef,squid
Reviewed:
Affected Versions:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Tags (freeform):
backport_processed
Fixed In:
v20.0.0-666-g6fc1a6dd92
Released In:
v20.2.0~792
Upkeep Timestamp:
2025-11-01T01:00:37+00:00

Description

Allow passing metadata pool name and data pool name to the command ceph fs volume create, so that the users can use already created pools for creating FS/volume using it.


Related issues 3 (3 open0 closed)

Related to CephFS - Bug #70945: mgr/vol: volume create cmd deletes user-created pool if one of the pool passed is absentPending BackportRishabh Dave

Actions
Copied to CephFS - Backport #70605: reef: mgr/vol: allow passing pool names to "fs volume create" cmdQA TestingRishabh DaveActions
Copied to CephFS - Backport #70606: squid: mgr/vol: allow passing pool names to "fs volume create" cmdFix Under ReviewRishabh DaveActions
Actions #1

Updated by Rishabh Dave about 1 year ago · Edited

vshankar The Jira ticket mentions that these options should be added to command @fs subvolumegroup create as well as fs subvolume create. Any thoughts on this? It doesn't make sense to me since these commands can't create a new FS using pool names obtained through arguments.

Actions #2

Updated by Rishabh Dave about 1 year ago

  • Pull request ID set to 61732
Actions #3

Updated by Venky Shankar about 1 year ago

Rishabh Dave wrote in #note-1:

vshankar The Jira ticket mentions that these options should be added to command @fs subvolumegroup create as well as fs subvolume create. Any thoughts on this? It doesn't make sense to me since these commands can't create a new FS using pool names obtained through arguments.

I left some comments on the downstream ticket which I think needs to be answered before proceeding with such a change.

Actions #4

Updated by Rishabh Dave about 1 year ago · Edited

  • Status changed from New to Fix Under Review

Rishabh Dave wrote in #note-1:

vshankar The Jira ticket mentions that these options should be added to command @fs subvolumegroup create as well as fs subvolume create. Any thoughts on this? It doesn't make sense to me since these commands can't create a new FS using pool names obtained through arguments.

I had a chat with Venky about this today, adding options to pass data and metadata pools to commands fs subvolumegroup create and fs subvolume create doesn't seem appropriate. And we need to check and allow only empty pools for creation of new volume.

Actions #5

Updated by Venky Shankar about 1 year ago

  • Category set to Administration/Usability
  • Target version set to v20.0.0
  • Source set to Development
  • Backport set to reef,squid
Actions #6

Updated by Rishabh Dave 12 months ago

  • Status changed from Fix Under Review to Pending Backport
Actions #7

Updated by Rishabh Dave 12 months ago

  • Copied to Backport #70605: reef: mgr/vol: allow passing pool names to "fs volume create" cmd added
Actions #8

Updated by Rishabh Dave 12 months ago

  • Copied to Backport #70606: squid: mgr/vol: allow passing pool names to "fs volume create" cmd added
Actions #9

Updated by Upkeep Bot 12 months ago

  • Tags (freeform) set to backport_processed
Actions #10

Updated by Rishabh Dave 11 months ago

  • Related to Bug #70945: mgr/vol: volume create cmd deletes user-created pool if one of the pool passed is absent added
Actions #11

Updated by Upkeep Bot 9 months ago

  • Merge Commit set to 6fc1a6dd926a52773b98894e1092aea0d63d16ad
  • Fixed In set to v20.0.0-666-g6fc1a6dd926
  • Upkeep Timestamp set to 2025-07-08T18:07:34+00:00
Actions #12

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v20.0.0-666-g6fc1a6dd926 to v20.0.0-666-g6fc1a6dd926a
  • Upkeep Timestamp changed from 2025-07-08T18:07:34+00:00 to 2025-07-14T15:22:03+00:00
Actions #13

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v20.0.0-666-g6fc1a6dd926a to v20.0.0-666-g6fc1a6dd92
  • Upkeep Timestamp changed from 2025-07-14T15:22:03+00:00 to 2025-07-14T20:46:31+00:00
Actions #14

Updated by Patrick Donnelly 5 months ago

  • Tracker changed from Bug to Feature
  • Regression deleted (No)
  • Severity deleted (3 - minor)
Actions #15

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~792
  • Upkeep Timestamp changed from 2025-07-14T20:46:31+00:00 to 2025-11-01T01:00:37+00:00
Actions

Also available in: Atom PDF