mgr/vol: don't delete user-created pool in "volume create" command by rishabh-d-dave · Pull Request #62843 · ceph/ceph

rishabh-d-dave · 2025-04-16T08:59:57Z

If one of the pool names passed to "ceph fs volume create" command
(through --data-pool and --meta-pool name) is absent, don't delete the
pool that is present and passed to this command during the cleanup code
of this command.

IOW, "volume create" command should continue deleting pool created by it
but not delete pool created by the user.

Fixes: https://tracker.ceph.com/issues/70945

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

If one of the pool names passed to "ceph fs volume create" command (through --data-pool and --meta-pool name) is absent, don't delete the pool that is present and passed to this command during the cleanup code of this command. IOW, "volume create" command should continue deleting pool created by it but not delete pool created by the user. Fixes: https://tracker.ceph.com/issues/70945 Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2025-04-16T12:37:19Z

jenkins test make check

rishabh-d-dave · 2025-04-16T12:37:27Z

jenkins test make check arm64

rishabh-d-dave · 2025-04-16T12:37:32Z

jenkins test api

vshankar · 2025-04-17T03:11:25Z

jenkins test make check

vshankar · 2025-04-17T03:11:30Z

jenkins test make check arm64

"volume create" command. Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2025-04-17T05:36:55Z

removed f-string where it was redundant.

rishabh-d-dave · 2025-04-17T05:53:44Z

jenkins test api

rishabh-d-dave · 2025-04-17T06:57:52Z

jenkins test make check arm64

rishabh-d-dave · 2025-04-17T11:30:30Z

jenkins test make check arm64

rishabh-d-dave · 2025-04-17T11:30:34Z

jenkins test make check

rishabh-d-dave · 2025-04-17T11:31:04Z

jenkins test make check

rishabh-d-dave · 2025-04-17T16:20:34Z

jenkins test make check

rishabh-d-dave · 2025-04-18T04:35:40Z

jenkins test make check

vshankar · 2025-04-21T04:58:49Z

@rishabh-d-dave I see you added your testing tag and removed it later. We need this fix on priority. Can you please do the needful or let me know and I can put it to test.

rishabh-d-dave · 2025-04-21T05:52:26Z

@rishabh-d-dave I see you added your testing tag and removed it later. We need this fix on priority. Can you please do the needful or let me know and I can put it to test.

@vshankar Although from the changes on this PR, I don't the think the "make check" failure is related but the failure is persistent. Can you take a quick look at it and let me know what you think? Also, is there a way to run the exact failing test locally? Here's the link to the "make check" failure - https://jenkins.ceph.com/job/ceph-pull-requests/156439/

rishabh-d-dave · 2025-04-21T05:53:24Z

jenkins test make check

vshankar · 2025-04-21T06:18:21Z

@rishabh-d-dave I see you added your testing tag and removed it later. We need this fix on priority. Can you please do the needful or let me know and I can put it to test.

@vshankar Although from the changes on this PR, I don't the think the "make check" failure is related but the failure is persistent. Can you take a quick look at it and let me know what you think? Also, is there a way to run the exact failing test locally? Here's the link to the "make check" failure - https://jenkins.ceph.com/job/ceph-pull-requests/156439/

/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_rgw_iam_policy: error while loading shared libraries: /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libceph-common.so.2: file too short

Something probably has gone really wrong.

rishabh-d-dave · 2025-04-21T06:20:31Z

@rishabh-d-dave I see you added your testing tag and removed it later. We need this fix on priority. Can you please do the needful or let me know and I can put it to test.

@vshankar Although from the changes on this PR, I don't the think the "make check" failure is related but the failure is persistent. Can you take a quick look at it and let me know what you think? Also, is there a way to run the exact failing test locally? Here's the link to the "make check" failure - https://jenkins.ceph.com/job/ceph-pull-requests/156439/
/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_rgw_iam_policy: error while loading shared libraries: /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libceph-common.so.2: file too short
Something probably has gone really wrong.

I was looking at this failure -

Python Traceback

json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/pybind/test_ceph_argparse.py", line 49, in test_parse_json_funcsigs
    self.assertRaises(TypeError, parse_json_funcsigs, commands, 'cli')
  File "/usr/lib/python3.10/unittest/case.py", line 738, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/usr/lib/python3.10/unittest/case.py", line 201, in handle
    callable_obj(*args, **kwargs)
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/ceph_argparse.py", line 1100, in parse_json_funcsigs
    raise e
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/ceph_argparse.py", line 1097, in parse_json_funcsigs
    overall = json.loads(s)
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

rishabh-d-dave · 2025-04-22T15:52:03Z

This PR is under test in https://tracker.ceph.com/issues/71020.

vshankar · 2025-04-24T12:32:37Z

@rishabh-d-dave status of this? This needs to be included in the backports (downstream too).

rishabh-d-dave · 2025-04-24T12:36:50Z

@rishabh-d-dave status of this? This needs to be included in the backports (downstream too).

I am going through the QA run, if everything looks fine in it, it can be merged.

rishabh-d-dave

There were not related failures, QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20250426123842-debug.

rishabh-d-dave added bug-fix cephfs Ceph File System tests pybind needs-review labels Apr 16, 2025

rishabh-d-dave requested review from a team and vshankar April 16, 2025 08:59

rishabh-d-dave force-pushed the vols-user-pool branch from 7bf4583 to ff67c8a Compare April 16, 2025 09:02

rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Apr 16, 2025

vshankar approved these changes Apr 16, 2025

View reviewed changes

rishabh-d-dave removed the wip-rishabh-testing Rishabh's testing label label Apr 16, 2025

qa/cephfs: test that user created pool is not deleted by...

ad1716f

"volume create" command. Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave force-pushed the vols-user-pool branch from ff67c8a to ad1716f Compare April 17, 2025 05:36

rishabh-d-dave added the wip-rishabh-testing2 label Apr 21, 2025

rishabh-d-dave commented Apr 30, 2025

View reviewed changes

rishabh-d-dave merged commit 43cf7f9 into ceph:main Apr 30, 2025
12 checks passed

Conversation

rishabh-d-dave commented Apr 16, 2025

Contribution Guidelines

Checklist

Uh oh!

rishabh-d-dave commented Apr 16, 2025

Uh oh!

rishabh-d-dave commented Apr 16, 2025

Uh oh!

rishabh-d-dave commented Apr 16, 2025

Uh oh!

vshankar commented Apr 17, 2025

Uh oh!

vshankar commented Apr 17, 2025

Uh oh!

rishabh-d-dave commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rishabh-d-dave commented Apr 17, 2025

Uh oh!

rishabh-d-dave commented Apr 17, 2025

Uh oh!

rishabh-d-dave commented Apr 17, 2025

Uh oh!

rishabh-d-dave commented Apr 17, 2025

Uh oh!

rishabh-d-dave commented Apr 17, 2025

Uh oh!

rishabh-d-dave commented Apr 17, 2025

Uh oh!

rishabh-d-dave commented Apr 18, 2025

Uh oh!

vshankar commented Apr 21, 2025

Uh oh!

rishabh-d-dave commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rishabh-d-dave commented Apr 21, 2025

Uh oh!

vshankar commented Apr 21, 2025

Uh oh!

rishabh-d-dave commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rishabh-d-dave commented Apr 22, 2025

Uh oh!

vshankar commented Apr 24, 2025

Uh oh!

rishabh-d-dave commented Apr 24, 2025

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rishabh-d-dave commented Apr 17, 2025 •

edited

Loading

rishabh-d-dave commented Apr 21, 2025 •

edited

Loading

rishabh-d-dave commented Apr 21, 2025 •

edited

Loading