reef: blk/kerneldevice: some fix for device discard by YiteGu · Pull Request #62481 · ceph/ceph

YiteGu · 2025-03-25T07:39:58Z

blk/kernel: bring "bdev_async_discard" config parameter back.
blk/kerneldevice: add perfcounter for block async discard.
blk/kerneldevice: count ops not bytes in discard_op perf counter.
blk/kerneldevice: fix invalid iterator usage after erase in discard_queued traversal.
blk/kernel: New perf counter to view amount of discard threads

backport of #62254, #58952, #62150, #62471, #62251
parent tracker: https://tracker.ceph.com/issues/70335, https://tracker.ceph.com/issues/70636

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

src/blk/kernel/KernelDevice.cc

ifed01 · 2025-03-28T15:24:38Z

@YiteGu - do we reaaly need feeb02e be the part of this PR. IMO it looks completely unrelated. May be have another backport PR for that?

ifed01 · 2025-03-28T15:29:02Z

Mind backporting this commit as well? 24d6002

YiteGu · 2025-03-29T11:20:18Z

@YiteGu - do we reaaly need feeb02e be the part of this PR. IMO it looks completely unrelated. May be have another backport PR for that?

Yes, It's really unrelated. The reason is that a92254f need feeb02e, otherwise, the conflict would be too great.

YiteGu · 2025-03-29T11:27:06Z

Mind backporting this commit as well? 24d6002

done

github-actions · 2025-04-08T21:33:24Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

YiteGu · 2025-04-10T09:40:59Z

@YiteGu - do we reaaly need feeb02e be the part of this PR. IMO it looks completely unrelated. May be have another backport PR for that?

Yes, It's really unrelated. The reason is that a92254f need feeb02e, otherwise, the conflict would be too great.

@ifed01 waiting PR(#62721) merged

ifed01 · 2025-04-10T11:19:00Z

@YiteGu - do we reaaly need feeb02e be the part of this PR. IMO it looks completely unrelated. May be have another backport PR for that?

Yes, It's really unrelated. The reason is that a92254f need feeb02e, otherwise, the conflict would be too great.

@ifed01 waiting PR(#62721) merged

Done, please rebase

To ensure backword compatibility for clusters with this parameter previously set to true. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit ea0df9a)

Signed-off-by: Yite Gu <yitegu0@gmail.com> (cherry picked from commit 90835d6)

Adding perfcounter helps to understand the status of async discard. Signed-off-by: Yite Gu <yitegu0@gmail.com> (cherry picked from commit f446f4c)

Fixes: https://tracker.ceph.com/issues/70335 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit d7467b0)

…ueued traversal fixes: https://tracker.ceph.com/issues/70636 Signed-off-by: Yite Gu <guyite@bytedance.com> (cherry picked from commit f1f0beb)

Signed-off-by: Yite Gu <guyite@bytedance.com> (cherry picked from commit c4528ec)

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 5aba1c9)

YiteGu · 2025-04-10T12:07:36Z

@YiteGu - do we reaaly need feeb02e be the part of this PR. IMO it looks completely unrelated. May be have another backport PR for that?

Yes, It's really unrelated. The reason is that a92254f need feeb02e, otherwise, the conflict would be too great.

@ifed01 waiting PR(#62721) merged

Done, please rebase

done

Naveenaidu · 2025-05-19T10:48:41Z

RADOS approved: https://tracker.ceph.com/issues/71030#note-9

YiteGu requested a review from a team as a code owner March 25, 2025 07:39

github-actions bot added bluestore common core tests labels Mar 25, 2025

github-actions bot added this to the reef milestone Mar 25, 2025

YiteGu requested a review from ifed01 March 25, 2025 07:40

YiteGu force-pushed the wip-some-fix-for-discard-reef branch from 8ff001b to 961f72d Compare March 25, 2025 11:56

ifed01 reviewed Mar 25, 2025

View reviewed changes

src/blk/kernel/KernelDevice.cc Outdated Show resolved Hide resolved

YiteGu force-pushed the wip-some-fix-for-discard-reef branch 2 times, most recently from 0f9fe4d to 4e55c4b Compare March 25, 2025 17:04

github-actions bot added the needs-rebase label Apr 8, 2025

ifed01 and others added 7 commits April 10, 2025 19:43

blk/kernel: bring "bdev_async_discard" config parameter back.

844cef2

To ensure backword compatibility for clusters with this parameter previously set to true. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit ea0df9a)

os/bluestore: passing device type name parameter to kernel device

2dd9e05

Signed-off-by: Yite Gu <yitegu0@gmail.com> (cherry picked from commit 90835d6)

blk/kerneldevice: add perfcounter for block async discard

71bc601

Adding perfcounter helps to understand the status of async discard. Signed-off-by: Yite Gu <yitegu0@gmail.com> (cherry picked from commit f446f4c)

blk/kerneldevice: count ops not bytes in discard_op perf counter

f66eb67

Fixes: https://tracker.ceph.com/issues/70335 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit d7467b0)

blk/kerneldevice: fix invalid iterator usage after erase in discard_q…

b2ab1e7

…ueued traversal fixes: https://tracker.ceph.com/issues/70636 Signed-off-by: Yite Gu <guyite@bytedance.com> (cherry picked from commit f1f0beb)

common/interval_set: erase() func should be return an iterator

082a1f3

Signed-off-by: Yite Gu <guyite@bytedance.com> (cherry picked from commit c4528ec)

blk/kernel: New perf counter to view amount of discard threads.

3850cb4

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 5aba1c9)

YiteGu force-pushed the wip-some-fix-for-discard-reef branch from 08ceea7 to 3850cb4 Compare April 10, 2025 11:57

github-actions bot removed the needs-rebase label Apr 10, 2025

YiteGu requested a review from ifed01 April 10, 2025 12:07

ifed01 approved these changes Apr 11, 2025

View reviewed changes

ifed01 added the needs-qa label Apr 11, 2025

SrinivasaBharath added the wip-bharath8-testing label Apr 22, 2025

ifed01 merged commit e2e30b5 into ceph:reef May 19, 2025
9 checks passed

SrinivasaBharath removed the wip-bharath8-testing label May 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reef: blk/kerneldevice: some fix for device discard#62481

reef: blk/kerneldevice: some fix for device discard#62481
ifed01 merged 7 commits intoceph:reeffrom
YiteGu:wip-some-fix-for-discard-reef

YiteGu commented Mar 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

ifed01 commented Mar 28, 2025

Uh oh!

ifed01 commented Mar 28, 2025

Uh oh!

YiteGu commented Mar 29, 2025

Uh oh!

YiteGu commented Mar 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

YiteGu commented Apr 10, 2025

Uh oh!

ifed01 commented Apr 10, 2025

Uh oh!

YiteGu commented Apr 10, 2025

Uh oh!

Naveenaidu commented May 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

YiteGu commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Uh oh!

ifed01 commented Mar 28, 2025

Uh oh!

ifed01 commented Mar 28, 2025

Uh oh!

YiteGu commented Mar 29, 2025

Uh oh!

YiteGu commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

YiteGu commented Apr 10, 2025

Uh oh!

ifed01 commented Apr 10, 2025

Uh oh!

YiteGu commented Apr 10, 2025

Uh oh!

Naveenaidu commented May 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YiteGu commented Mar 25, 2025 •

edited

Loading

YiteGu commented Mar 29, 2025 •

edited

Loading