Skip to content

blk/kernel: New perf counter to view amount of discard threads.#62251

Merged
ifed01 merged 1 commit intoceph:mainfrom
ifed01:wip-ifed-print-discard-threads
Mar 28, 2025
Merged

blk/kernel: New perf counter to view amount of discard threads.#62251
ifed01 merged 1 commit intoceph:mainfrom
ifed01:wip-ifed-print-discard-threads

Conversation

@ifed01
Copy link
Contributor

@ifed01 ifed01 commented Mar 12, 2025 •
edited by YiteGu
Loading

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@ifed01
blk/kernel: New perf counter to view amount of discard threads.
5aba1c9 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01 ifed01 requested a review from a team as a code owner March 12, 2025 15:19
@ifed01 ifed01 requested review from YiteGu and removed request for a team March 12, 2025 15:19
@github-actions github-actions bot added the core label Mar 12, 2025
@YiteGu
Copy link
Member

YiteGu commented Mar 13, 2025

  1. get bdev_async_discard_threads
ceph -c ceph.conf tell osd.0 perf dump | grep -A 17 blk-kernel-device-bluestore
    "blk-kernel-device-bluestore": {
        "discard_op": 29,
        "discard_op_lat": {
            "avgcount": 13,
            "sum": 0.005869912,
            "avgtime": 0.000451531
        },
        "discard_threads": 1
    },
    "blk-kernel-device-db": {
        "discard_op": 4,
        "discard_op_lat": {
            "avgcount": 4,
            "sum": 0.002501852,
            "avgtime": 0.000625463
        },
        "discard_threads": 1
    },
  1. adjust bdev_async_discard_threads
ceph -c ceph.conf tell osd.0 config set bdev_async_discard_threads 2
ceph -c ceph.conf tell osd.0 config get bdev_async_discard_threads
{
    "bdev_async_discard_threads": "2"
}
  1. get bdev_async_discard_threads
# ceph -c ceph.conf tell osd.0 perf dump | grep -A 17 blk-kernel-device-bluestore
    "blk-kernel-device-bluestore": {
        "discard_op": 29,
        "discard_op_lat": {
            "avgcount": 13,
            "sum": 0.005869912,
            "avgtime": 0.000451531
        },
        "discard_threads": 2
    },
    "blk-kernel-device-db": {
        "discard_op": 4,
        "discard_op_lat": {
            "avgcount": 4,
            "sum": 0.002501852,
            "avgtime": 0.000625463
        },
        "discard_threads": 2
    },

@YiteGu
Copy link
Member

YiteGu commented Mar 13, 2025

jenkins test make check

@YiteGu
Copy link
Member

YiteGu commented Mar 25, 2025

jenkins test make check

@aclamk aclamk added the aclamk-testing-nauvoo bluestore testing label Mar 25, 2025
@ifed01
Copy link
Contributor Author

ifed01 commented Mar 25, 2025

jenkins test make check arm

@ifed01
Copy link
Contributor Author

ifed01 commented Mar 25, 2025

jenkins test make check arm64

@ifed01
Copy link
Contributor Author

ifed01 commented Mar 25, 2025

ceph test api

@aclamk
Copy link
Contributor

aclamk commented Mar 28, 2025

Approved by https://tracker.ceph.com/issues/70705

@aclamk
Copy link
Contributor

aclamk commented Mar 28, 2025

jenkins test api

@ifed01 ifed01 merged commit adfd7e8 into ceph:main Mar 28, 2025
15 of 16 checks passed
@ifed01 ifed01 deleted the wip-ifed-print-discard-threads branch March 28, 2025 13:55
@YiteGu YiteGu mentioned this pull request Apr 10, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YiteGu YiteGu YiteGu approved these changes

Assignees

No one assigned

Labels

aclamk-testing-nauvoo bluestore testing core needs-qa performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ifed01 @YiteGu @aclamk @markhpc