Skip to content

blk/kerneldevice: fix invalid iterator usage after erase in discard_q…#62471

Merged
aclamk merged 2 commits intoceph:mainfrom
YiteGu:fix-invalid-iterator-usge-after-erase
Mar 28, 2025
Merged

blk/kerneldevice: fix invalid iterator usage after erase in discard_q…#62471
aclamk merged 2 commits intoceph:mainfrom
YiteGu:fix-invalid-iterator-usge-after-erase

Conversation

@YiteGu
Copy link
Member

@YiteGu YiteGu commented Mar 25, 2025 •
edited
Loading

fixes: https://tracker.ceph.com/issues/70636

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@YiteGu YiteGu requested a review from a team as a code owner March 25, 2025 03:10
@github-actions github-actions bot added the core label Mar 25, 2025
@YiteGu YiteGu requested review from NitzanMordhai and ifed01 March 25, 2025 03:12
@YiteGu YiteGu mentioned this pull request Mar 25, 2025
Merged
14 tasks
ifed01
ifed01 reviewed Mar 25, 2025
View reviewed changes
@ifed01
Copy link
Contributor

ifed01 commented Mar 25, 2025

Tracker reference in "Fixes" looks wrong.

YiteGu added 2 commits March 25, 2025 19:24
@YiteGu
blk/kerneldevice: fix invalid iterator usage after erase in discard_q…
f1f0beb 
…ueued traversal

fixes: https://tracker.ceph.com/issues/70636

Signed-off-by: Yite Gu <guyite@bytedance.com>
@YiteGu
common/interval_set: erase() func should be return an iterator
c4528ec 
Signed-off-by: Yite Gu <guyite@bytedance.com>
@YiteGu YiteGu force-pushed the fix-invalid-iterator-usge-after-erase branch from 07fcf9c to c4528ec Compare March 25, 2025 11:30
@YiteGu
Copy link
Member Author

YiteGu commented Mar 25, 2025 •
edited
Loading

Tracker reference in "Fixes" looks wrong.

updated

@YiteGu YiteGu requested review from aclamk and ifed01 March 25, 2025 11:33
@ifed01 ifed01 mentioned this pull request Mar 25, 2025
Merged
14 tasks
@aclamk aclamk added the aclamk-testing-nauvoo bluestore testing label Mar 25, 2025
@YiteGu
Copy link
Member Author

YiteGu commented Mar 25, 2025

jenkins test make check

@aclamk
Copy link
Contributor

aclamk commented Mar 28, 2025

Approved by https://tracker.ceph.com/issues/70705

@aclamk aclamk merged commit 4dd7504 into ceph:main Mar 28, 2025
13 checks passed
@YiteGu YiteGu mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ifed01 ifed01 ifed01 approved these changes

@aclamk aclamk aclamk approved these changes

@NitzanMordhai NitzanMordhai Awaiting requested review from NitzanMordhai

Assignees

No one assigned

Labels

aclamk-testing-nauvoo bluestore testing bug-fix core needs-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YiteGu @ifed01 @aclamk