Skip to content

blk/kerneldevice: add perfcounter for block async discard#58952

Merged
ifed01 merged 2 commits intoceph:mainfrom
YiteGu:add-perfcounter-for-blk-discard
Sep 25, 2024
Merged

blk/kerneldevice: add perfcounter for block async discard#58952
ifed01 merged 2 commits intoceph:mainfrom
YiteGu:add-perfcounter-for-blk-discard

Conversation

@YiteGu
Copy link
Member

@YiteGu YiteGu commented Jul 31, 2024

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@YiteGu YiteGu changed the title add perfcounter for block async discard blk/kerneldevice: add perfcounter for block async discard Jul 31, 2024
@YiteGu YiteGu force-pushed the add-perfcounter-for-blk-discard branch from ac60ce3 to b28e91a Compare July 31, 2024 12:41
@YiteGu
Copy link
Member Author

YiteGu commented Jul 31, 2024

jenkins test make check

@YiteGu YiteGu force-pushed the add-perfcounter-for-blk-discard branch from b28e91a to e81e74e Compare August 8, 2024 06:30
@github-actions
Copy link

github-actions bot commented Aug 8, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@YiteGu YiteGu force-pushed the add-perfcounter-for-blk-discard branch from e81e74e to 3f3efa8 Compare August 8, 2024 08:51
@ifed01 ifed01 added the needs-qa label Aug 8, 2024
@YiteGu YiteGu force-pushed the add-perfcounter-for-blk-discard branch from 3f3efa8 to d6590fd Compare August 8, 2024 10:37
Signed-off-by: Yite Gu <yitegu0@gmail.com>
@YiteGu YiteGu force-pushed the add-perfcounter-for-blk-discard branch from d6590fd to bfc7799 Compare August 8, 2024 11:18
@YiteGu
Copy link
Member Author

YiteGu commented Aug 8, 2024

jenkins test make check

Adding perfcounter helps to understand the status of async discard.

Signed-off-by: Yite Gu <yitegu0@gmail.com>
@YiteGu YiteGu force-pushed the add-perfcounter-for-blk-discard branch from bfc7799 to f446f4c Compare August 12, 2024 02:40
@YiteGu
Copy link
Member Author

YiteGu commented Aug 12, 2024

jenkins test api

2 similar comments
@YiteGu
Copy link
Member Author

YiteGu commented Aug 13, 2024

jenkins test api

@YiteGu
Copy link
Member Author

YiteGu commented Aug 13, 2024

jenkins test api

@kamoltat
Copy link
Member

@ifed01 ifed01 merged commit 327d209 into ceph:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants