mon/NVMeofGw*: code cleanups, function comments, reenable nvmeof paxos service#59388
mon/NVMeofGw*: code cleanups, function comments, reenable nvmeof paxos service#59388
Conversation
Signed-off-by: Samuel Just <sjust@redhat.com>
fsm_handle_gw_delete may read it without first setting it. Signed-off-by: Samuel Just <sjust@redhat.com>
9217bb7 to
1cc14e2
Compare
|
jenkins test docs |
|
Pushed testing branch https://shaman.ceph.com/builds/ceph/wip-sjust-nvmeof-testing-2024-08-21 with #59240, #59385, #59388, and #59366 |
Sam have bundled ceph/ceph#59388 with ceph/ceph#59240, ceph/ceph#59385, ceph/ceph#59388, and ceph/ceph#59366 in a testing branch https://shaman.ceph.com/builds/ceph/wip-sjust-nvmeof-testing-2024-08-21 Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
- Replace loop and check with std::map::find() - Clarify comments, variable names - Add header comment. Signed-off-by: Samuel Just <sjust@redhat.com>
- Avoid indexing into creating_gws repeatedly - Avoid creating empty entry for group_key if not present - Add header comment. Signed-off-by: Samuel Just <sjust@redhat.com>
- Avoid indexing into creating_gws repeatedly - Avoid creating empty entry for group_key if not present - Add header comment Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
- use structured binding in loops - avoid operator[] for created_gws within loop Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
1cc14e2 to
b51f059
Compare
- avoid extra operator[] into created_gws while looping over created_gws - use emplace rather than construction + copy - pass references to add_grp_id - add header comment Signed-off-by: Samuel Just <sjust@redhat.com>
Avoids operator[] on created_gws while looping over created_gws in cfg_delete_gw. Signed-off-by: Samuel Just <sjust@redhat.com>
- make validate_gw_map const - avoid extra outer loop - print number of active gws Signed-off-by: Samuel Just <sjust@redhat.com>
This reverts commit 6911df2. Signed-off-by: Samuel Just <sjust@redhat.com>
b51f059 to
b335d0c
Compare
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e