.gitmodules: remove shallow=true config from nvmeof/gateway#59366
Merged
.gitmodules: remove shallow=true config from nvmeof/gateway#59366
Conversation
shallow=true seems to prevent the checkout from actually finding the correct sha1. Fixes: https://tracker.ceph.com/issues/67640 Signed-off-by: Samuel Just <sjust@redhat.com>
Member
|
Seems fine to me but I haven't tested this myself. |
cbodley
approved these changes
Aug 21, 2024
Contributor
|
https://jenkins.ceph.com/job/ceph-api/80188/
tracked in https://tracker.ceph.com/issues/62972 |
Contributor
|
jenkins test api |
Contributor
|
https://jenkins.ceph.com/job/ceph-pull-requests/141821/
|
Contributor
|
jenkins test make check |
Contributor
|
https://jenkins.ceph.com/job/ceph-pull-requests/141863/
|
Contributor
|
jenkins test make check |
This was referenced Aug 21, 2024
baum
pushed a commit
to baum/ceph-nvmeof
that referenced
this pull request
Aug 22, 2024
Sam have bundled ceph/ceph#59388 with ceph/ceph#59240, ceph/ceph#59385, ceph/ceph#59388, and ceph/ceph#59366 in a testing branch https://shaman.ceph.com/builds/ceph/wip-sjust-nvmeof-testing-2024-08-21 Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
batrick
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shallow=true seems to prevent the checkout from actually finding the correct sha1.
Fixes: https://tracker.ceph.com/issues/67640
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e