Skip to content

mon: handle gw fast-reboot, proper handle of gw delete scenarios#59385

Merged
caroav merged 1 commit intoceph:mainfrom
leonidc:wip-leonidc-20242108-fixing-gw-bugs
Aug 28, 2024
Merged

mon: handle gw fast-reboot, proper handle of gw delete scenarios#59385
caroav merged 1 commit intoceph:mainfrom
leonidc:wip-leonidc-20242108-fixing-gw-bugs

Conversation

@leonidc
Copy link
Contributor

@leonidc leonidc commented Aug 21, 2024

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@leonidc leonidc requested a review from a team as a code owner August 21, 2024 16:31
Copy link
Contributor

@athanatos athanatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit is missing a signed-off by -- required on all commits. LGTM once the commit message and the below changes are made.

@athanatos athanatos changed the title Wip leonidc 20242108 fixing gw bugs mon: handle gw fast-reboot, proper handle of gw delete scenarios Aug 21, 2024
@athanatos
Copy link
Contributor

@caroav
Copy link
Contributor

caroav commented Aug 25, 2024

jenkins test api

@caroav
Copy link
Contributor

caroav commented Aug 25, 2024

jenkins test make check

@leonidc leonidc force-pushed the wip-leonidc-20242108-fixing-gw-bugs branch 2 times, most recently from ce8ca7f to a0ec91c Compare August 26, 2024 08:17
… gw delete scenarios

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
@leonidc leonidc force-pushed the wip-leonidc-20242108-fixing-gw-bugs branch from a0ec91c to 8d402e3 Compare August 26, 2024 08:24
@leonidc
Copy link
Contributor Author

leonidc commented Aug 26, 2024

jenkins test api

@caroav caroav merged commit ee8354d into ceph:main Aug 28, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this added a duplicate copy of ceph/src/mon/NVMeofGwMap.h at ceph/NVMeofGwMap.h. i opened #59840 to remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants