fix(overflowmenu): added typing to align prop by jose-biescas · Pull Request #19131 · carbon-design-system/carbon

jose-biescas · 2025-04-14T15:03:45Z

Adds a type to the align prop in OverflowMenu

Changelog

New

Added align property

Testing / Reviewing

Go to the Default storybook for OverflowMenu and the align property can be controlled via a dropdown with allowed prop values

github-actions · 2025-04-14T15:04:06Z

Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:

I have read the DCO document and I hereby sign the DCO.

1 out of 2 committers have signed the DCO.
✅ (tay1orjones)[https://github.com/tay1orjones]
❌ @jose-biescas
jose-biescas seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the DCO Assistant Lite bot.}

jose-biescas · 2025-04-14T15:07:09Z

I have read the DCO document and I hereby sign the DCO.

netlify · 2025-04-14T15:10:32Z

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	`2731b08`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/67fd23d5e677170008b2fdeb
😎 Deploy Preview	https://deploy-preview-19131--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-04-14T15:13:04Z

✅ Deploy Preview for v11-carbon-web-components ready!

Name	Link
🔨 Latest commit	`3c31b3f`
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-web-components/deploys/680291ccb506390008a250c1
😎 Deploy Preview	https://deploy-preview-19131--v11-carbon-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-04-14T15:14:32Z

✅ Deploy Preview for v11-carbon-react ready!

Name	Link
🔨 Latest commit	`3c31b3f`
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-react/deploys/680291cc7fb8a20008a8cb3b
😎 Deploy Preview	https://deploy-preview-19131--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jose-biescas · 2025-04-14T16:29:43Z

recheck

tay1orjones

A couple comments but otherwise looks good to me. Thanks for taking this on!

Having align alongside direction and flipped is probably going to lead to some confusion. Prop/type comments help though since they explicitly mention "tooltip". The new OverflowMenu implementation calls it tooltipAlignment to avoid this confusion.

This being the old implementation though I don't think it's necessary to try and get a new tooltipAlignment to work alongside the existing align that some might be using. Plus it would add another layer of complexity having to iron out the types for all that.

I just want to make note of this, there's no action for you to take here.

* chore(overflowmenu): added todo waiting on consolidation of carbon-design-system#19081 * chore(overflowmenu-storybook): updated storybook align options to latest list

tay1orjones · 2025-04-18T17:56:54Z

@jose-biescas The first commit a9b073c was made with a user/config that doesn't match your github.com profile, so the DCO bot will continually fail on this one. We can override it for this PR though, just something to be aware of next time.

jose-biescas · 2025-04-18T17:59:32Z

@tay1orjones Apologies for that, not sure what happened. Will make sure future commits are also verified/signed. Thank you!

codecov · 2025-04-18T18:12:16Z

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (e073464) to head (3c31b3f).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...react/src/components/OverflowMenu/OverflowMenu.tsx	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #19131      +/-   ##
==========================================
- Coverage   84.37%   84.36%   -0.02%     
==========================================
  Files         388      388              
  Lines       14547    14550       +3     
  Branches     4774     4753      -21     
==========================================
+ Hits        12274    12275       +1     
- Misses       2113     2116       +3     
+ Partials      160      159       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…9131) * fix(overflowmenu): added typing to align prop * chore(overflowmenu): removed unnecessary types * chore(overflowmenu): added todo waiting on consolidation of carbon-design-system#19081 * chore(overflowmenu-storybook): updated storybook align options to latest list --------- Co-authored-by: jose-biescas <jose.biescas@ibm.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>

* fix(OverflowMenu): fix types Fix OverflowMenuProps to include properties that get passed through to IconButton, for example align, autoAlign, and tooltip. Relatedly, fix TableToolbarMenuProps to extend OverflowMenuProps. I also removed the aria-label as it's redundant with iconDescription. * chore(OverflowMenu): align is inherited from IconButtonProps PR #19131 added align manually but I changed it to inherit from IconButtonProps (rather than repeating the definition). --------- Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com>

…9131) * fix(overflowmenu): added typing to align prop * chore(overflowmenu): removed unnecessary types * chore(overflowmenu): added todo waiting on consolidation of carbon-design-system#19081 * chore(overflowmenu-storybook): updated storybook align options to latest list --------- Co-authored-by: jose-biescas <jose.biescas@ibm.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>

* fix(OverflowMenu): fix types Fix OverflowMenuProps to include properties that get passed through to IconButton, for example align, autoAlign, and tooltip. Relatedly, fix TableToolbarMenuProps to extend OverflowMenuProps. I also removed the aria-label as it's redundant with iconDescription. * chore(OverflowMenu): align is inherited from IconButtonProps PR carbon-design-system#19131 added align manually but I changed it to inherit from IconButtonProps (rather than repeating the definition). --------- Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com>

jose-biescas requested a review from a team as a code owner April 14, 2025 15:03

jose-biescas requested review from a team, 2nikhiltom and alisonjoseph April 14, 2025 15:03

fix(overflowmenu): added typing to align prop

a9b073c

jose-biescas force-pushed the bug-18957-overflow-align-type branch from 2731b08 to a9b073c Compare April 14, 2025 16:26

adamalston reviewed Apr 14, 2025

View reviewed changes

Comment thread packages/react/src/components/OverflowMenu/OverflowMenu.tsx Outdated

Comment thread packages/react/src/components/OverflowMenu/OverflowMenu.tsx Outdated

Comment thread packages/react/src/components/OverflowMenu/OverflowMenu.tsx

tay1orjones requested changes Apr 14, 2025

View reviewed changes

Comment thread packages/react/src/components/OverflowMenu/OverflowMenu.tsx Outdated

Comment thread packages/react/src/components/OverflowMenu/OverflowMenu.stories.js

chore(overflowmenu): removed unnecessary types

85e7d18

* chore(overflowmenu): added todo waiting on consolidation of carbon-design-system#19081 * chore(overflowmenu-storybook): updated storybook align options to latest list

tay1orjones approved these changes Apr 18, 2025

View reviewed changes

Merge branch 'main' into bug-18957-overflow-align-type

3c31b3f

tay1orjones enabled auto-merge April 18, 2025 17:54

tay1orjones added the status: one more review 👀 label Apr 18, 2025

kennylam approved these changes Apr 20, 2025

View reviewed changes

tay1orjones added this pull request to the merge queue Apr 20, 2025

2nikhiltom approved these changes Apr 20, 2025

View reviewed changes

2nikhiltom added status: ready to merge 🎉 and removed status: one more review 👀 labels Apr 20, 2025

Merged via the queue into carbon-design-system:main with commit 2fcb9f0 Apr 20, 2025

wkeese mentioned this pull request May 23, 2025

fix(OverflowMenu): fix types #19158

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(overflowmenu): added typing to align prop#19131

fix(overflowmenu): added typing to align prop#19131
tay1orjones merged 3 commits into
carbon-design-system:mainfrom
jose-biescas:bug-18957-overflow-align-type

jose-biescas commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 14, 2025 •

edited

Loading

Uh oh!

jose-biescas commented Apr 14, 2025

Uh oh!

netlify Bot commented Apr 14, 2025

Uh oh!

netlify Bot commented Apr 14, 2025 •

edited

Loading

Uh oh!

netlify Bot commented Apr 14, 2025 •

edited

Loading

Uh oh!

jose-biescas commented Apr 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tay1orjones left a comment

Uh oh!

Uh oh!

Uh oh!

tay1orjones commented Apr 18, 2025

Uh oh!

jose-biescas commented Apr 18, 2025

Uh oh!

codecov Bot commented Apr 18, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jose-biescas commented Apr 14, 2025

Changelog

Testing / Reviewing

Uh oh!

github-actions Bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jose-biescas commented Apr 14, 2025

Uh oh!

netlify Bot commented Apr 14, 2025

✅ Deploy Preview for carbon-elements ready!

Uh oh!

netlify Bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for v11-carbon-web-components ready!

Uh oh!

netlify Bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for v11-carbon-react ready!

Uh oh!

jose-biescas commented Apr 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tay1orjones left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tay1orjones commented Apr 18, 2025

Uh oh!

jose-biescas commented Apr 18, 2025

Uh oh!

codecov Bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Apr 14, 2025 •

edited

Loading

netlify Bot commented Apr 14, 2025 •

edited

Loading

netlify Bot commented Apr 14, 2025 •

edited

Loading

codecov Bot commented Apr 18, 2025 •

edited

Loading