fix(OverflowMenu): fix types#19158
Merged
kennylam merged 3 commits intoJun 26, 2025
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19158 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 373 373
Lines 14715 14715
Branches 4796 4796
=======================================
Hits 12457 12457
Misses 2108 2108
Partials 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix OverflowMenuProps to include properties that get passed through to IconButton, for example align, autoAlign, and tooltip. Relatedly, fix TableToolbarMenuProps to extend OverflowMenuProps. I also removed the aria-label as it's redundant with iconDescription.
8588779 to
0d42224
Compare
PR #19131 added align manually but I changed it to inherit from IconButtonProps (rather than repeating the definition).
9a54eed to
009cbd2
Compare
kennylam
approved these changes
Jun 26, 2025
Merged
via the queue into
carbon-design-system:main
with commit Jun 26, 2025
5bbffc4
36 checks passed
heloiselui
pushed a commit
to guidari/carbon
that referenced
this pull request
Jul 11, 2025
* fix(OverflowMenu): fix types Fix OverflowMenuProps to include properties that get passed through to IconButton, for example align, autoAlign, and tooltip. Relatedly, fix TableToolbarMenuProps to extend OverflowMenuProps. I also removed the aria-label as it's redundant with iconDescription. * chore(OverflowMenu): align is inherited from IconButtonProps PR carbon-design-system#19131 added align manually but I changed it to inherit from IconButtonProps (rather than repeating the definition). --------- Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com>
AlexanderMelox
pushed a commit
to AlexanderMelox/carbon
that referenced
this pull request
Apr 28, 2026
* fix(OverflowMenu): fix types Fix OverflowMenuProps to include properties that get passed through to IconButton, for example align, autoAlign, and tooltip. Relatedly, fix TableToolbarMenuProps to extend OverflowMenuProps. I also removed the aria-label as it's redundant with iconDescription. * chore(OverflowMenu): align is inherited from IconButtonProps PR carbon-design-system#19131 added align manually but I changed it to inherit from IconButtonProps (rather than repeating the definition). --------- Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
OverflowMenuPropsto include properties that get passed through toIconButton, for examplealign,autoAlign, andtooltip.The alternative is to list the properties manually, which is what #19131 did for the
alignprop, but not for the other props.Relatedly, fix
TableToolbarMenuPropsto extendOverflowMenuProps. I also removed thearia-labelas it's redundant withiconDescription.Changelog
Changed
OverflowMenuandTableToolbar.Testing / Reviewing
Built carbon, and also built my app with the new carbon.