refactor: consolidate Popover align mapping functionality#19081
Merged
preetibansalui merged 5 commits intoApr 30, 2025
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19081 +/- ##
==========================================
+ Coverage 84.37% 84.50% +0.12%
==========================================
Files 385 384 -1
Lines 14539 14480 -59
Branches 4771 4738 -33
==========================================
- Hits 12268 12236 -32
+ Misses 2111 2086 -25
+ Partials 160 158 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jose-biescas
added a commit
to jose-biescas/carbon
that referenced
this pull request
Apr 15, 2025
* chore(overflowmenu): added todo waiting on consolidation of carbon-design-system#19081 * chore(overflowmenu-storybook): updated storybook align options to latest list
kennylam
approved these changes
Apr 19, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 20, 2025
* fix(overflowmenu): added typing to align prop * chore(overflowmenu): removed unnecessary types * chore(overflowmenu): added todo waiting on consolidation of #19081 * chore(overflowmenu-storybook): updated storybook align options to latest list --------- Co-authored-by: jose-biescas <jose.biescas@ibm.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
preetibansalui
approved these changes
Apr 22, 2025
Merged
via the queue into
carbon-design-system:main
with commit Apr 30, 2025
09985f6
13 checks passed
AlexanderMelox
pushed a commit
to AlexanderMelox/carbon
that referenced
this pull request
Jun 10, 2025
…9131) * fix(overflowmenu): added typing to align prop * chore(overflowmenu): removed unnecessary types * chore(overflowmenu): added todo waiting on consolidation of carbon-design-system#19081 * chore(overflowmenu-storybook): updated storybook align options to latest list --------- Co-authored-by: jose-biescas <jose.biescas@ibm.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
AlexanderMelox
pushed a commit
to AlexanderMelox/carbon
that referenced
this pull request
Jun 10, 2025
…-design-system#19081) * refactor: consolidate popover align mapping functionality * refactor: address todo
heloiselui
pushed a commit
to guidari/carbon
that referenced
this pull request
Jul 11, 2025
…9131) * fix(overflowmenu): added typing to align prop * chore(overflowmenu): removed unnecessary types * chore(overflowmenu): added todo waiting on consolidation of carbon-design-system#19081 * chore(overflowmenu-storybook): updated storybook align options to latest list --------- Co-authored-by: jose-biescas <jose.biescas@ibm.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
heloiselui
pushed a commit
to guidari/carbon
that referenced
this pull request
Jul 11, 2025
…-design-system#19081) * refactor: consolidate popover align mapping functionality * refactor: address todo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19079
Consolidated
Popoveralignmapping functionality.Changelog
Removed
Popoveralignmapping functionality.Testing / Reviewing
yarn test packages/react