chore(deps): bump s3 to v1.97.3 + containerd/v2 to v2.2.4#984
Merged
Conversation
Closes Dependabot alert bsv-blockchain#72. EventStream decoder DoS panic affects s3 v < 1.97.3. Prior bump in PR bsv-blockchain#925 pinned to v1.96.4 because GH advisory indicated 1.96.x was sufficient at the time; advisory was later refined to require 1.97.3+.
Closes Dependabot alert bsv-blockchain#101. containerd user-ID handling bypass allows runAsNonRoot evasion in versions < 2.2.4; patched in 2.2.4. Indirect dep pulled via the docker/containerd toolchain. Conservative bump within the v2.2.x line.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
🤖 Claude Code Review Status: Complete No issues found. This is a well-executed security dependency update. The changes are minimal (go.mod and go.sum only), thoroughly tested per AGENTS.md requirements, and directly address two Dependabot security alerts:
All verification commands from AGENTS.md were executed and passed, including race detection and vulnerability scanning. |
Contributor
Benchmark Comparison ReportBaseline: Current: Summary
All benchmark results (sec/op)
Threshold: >10% with p < 0.05 | Generated: 2026-06-01 15:23 UTC |
ordishs
approved these changes
May 29, 2026
ordishs
left a comment
Collaborator
There was a problem hiding this comment.
Approve. Minimal, well-tested security dependency bump closing two Dependabot alerts (s3 EventStream DoS panic, containerd runAsNonRoot bypass). Changes limited to go.mod/go.sum with thorough test coverage documented. Optional suggestion: run go mod tidy to prune ~10 stale checksum entries from go.sum.
# Conflicts: # go.mod
c2b75ab to
0c33a65
Compare
|
freemans13
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps 2 Go dependencies to close 2 open Dependabot alerts surfaced after the initial 2026-05-21 triage:
github.com/aws/aws-sdk-go-v2/service/s3v1.96.4 → v1.97.3 — closes alert Initial Block Download is slow... Reverse scanning could lead to improved performance #72 (EventStream decoder DoS panic, GHSA refined the patched version to 1.97.3+ after PR chore(deps): bump minor versions for vulnerability fixes #925 merged with the then-current 1.96.4 floor).github.com/containerd/containerd/v2v2.2.2 → v2.2.4 (indirect dep) — closes alert Use max system file limits, instead of settings #101 (user-ID handling bypass allows runAsNonRoot evasion, patched in 2.2.4).2 commits, one per package.
Test plan
go build ./...go test ./...— 8193 tests pass in 151 packagesgo test -race ./...— exit 0, no race warningsgo vet ./...— only the 4 pre-existing test/utils issuesgolangci-lint run --timeout=5m --disable gosec --disable prealloc— no issues foundstaticcheck ./...— cleangovulncheck ./...— s3 and containerd/v2 no longer flaggedgo test -race ./stores/blob/...(s3) andgo test -race ./util/...(containerd transitive) passOut of scope
tolerable_riskseparately — docker/docker is test-tooling only and the vulnerable code paths are not exercised at runtime.Source: fresh inventory pulled 2026-05-29 against the post-PR-#968 main branch.