Skip to content

Use max system file limits, instead of settings#101

Merged
icellan merged 3 commits into
bsv-blockchain:mainfrom
icellan:system-file-limits
Nov 4, 2025
Merged

Use max system file limits, instead of settings#101
icellan merged 3 commits into
bsv-blockchain:mainfrom
icellan:system-file-limits

Conversation

@icellan

@icellan icellan commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@icellan icellan requested a review from freemans13 November 4, 2025 11:00
@icellan icellan requested a review from oskarszoon November 4, 2025 11:01
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

🤖 Claude Code Review

Status: Complete


Current Review:
No issues found. All previously reported concerns have been addressed:

History:

  • ✅ Fixed: Silent error handling - now includes proper error messages and fallback logic
  • ✅ Fixed: Validation failure risk - system limits are clamped to MaxSemaphoreLimit before calculations
  • ✅ Fixed: Platform dependency concern was noted and thread resolved

The PR correctly:

  • Reads system ulimit values with proper error handling
  • Clamps values to MaxSemaphoreLimit (256,000) before calculating read/write limits
  • Falls back to configured settings if system limits cannot be determined
  • Maintains the 3:1 ratio for read:write concurrency
  • Uses exported constants (MinSemaphoreLimit, MaxSemaphoreLimit) for validation

Comment thread cmd/teranode/daemon.go Outdated
Comment thread cmd/teranode/daemon.go Outdated
Comment thread cmd/teranode/daemon.go Outdated
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2025

Copy link
Copy Markdown

@icellan icellan merged commit 8d50326 into bsv-blockchain:main Nov 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants