fix(p2p): remove BlockAssemblyDetails from node status#67
Closed
ordishs wants to merge 27 commits into
Closed
Conversation
… support - Fix capacity calculation in BlockHeaderMeta.Bytes() to include all fields - Add ProcessedAt field to BlockHeaderMeta struct for tracking block processing time - Update serialization/deserialization to handle ProcessedAt timestamp (8 bytes) - Add ProcessedAt to protobuf GetBlockHeaderResponse with proper timestamp type conversion - Update HTTP API responses to include Invalid and ProcessedAt fields - Fix frontend date parsing to handle RFC 3339 timestamp format from JSON API
- Add hasCoinbaseColumn parameter to processBlockHeadersRows - Fix GetBlockHeadersFromOldest to include processed_at column - Remove dynamic column detection to improve performance - Fix variable shadowing with err declaration
…ions Replace detailed block assembly state with simpler subtree_count field in websocket notifications to reduce message size and coupling
Add icon button to clear sorting on network nodes table and ensure current node appears at top only when no user sorting is active
Keep ancestors page accessible via direct URL but remove from menu
Replace custom hash rendering with reusable RenderHashWithMiner component to provide consistent tooltip display and copy-to-clipboard functionality across the admin page's recently invalidated blocks table.
…l pointer panic Remove BlockAssemblyDetails field from NodeStatusMessage struct and eliminate attempts to access SubtreeCount/TxCount fields that caused segmentation fault in handleNodeStatusTopic. Also remove unused blockassembly_api import.
ordishs
added a commit
to ordishs/teranode
that referenced
this pull request
Jan 12, 2026
Add Known Limitations section explaining why seeded blocks don't have miner information in V1 format: - V1 headers file doesn't include coinbase transactions - Miner info requires coinbase tx to extract via util.ExtractCoinbaseMiner() - V2 format (commit bb10c7d) will resolve this when merged - Document workaround and that this doesn't affect validation Addresses issue bsv-blockchain#67 from teranode-review
Merged
7 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan